Fix DaedalusIPC race-condition when sending 'Started' too quickly #1037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Nov 14, 2019
1037: Fix DaedalusIPC race-condition when sending 'Started' too quickly r=KtorZ a=KtorZ # Issue Number <!-- Put here a reference to the issue this PR relates to and which requirements it tackles --> #1036 # Overview <!-- Detail in a few bullet points the work accomplished in this PR --> - [x] I have artificially reproduced the issue in our mock-daedalus and saw it fails (wait infinitely) - [x] I have added some retry logic to re-send `Started` every second if Daedalus has shown any sign of life. # Comments <!-- Additional comments or screenshots to attach if any --> <!-- Don't forget to: ✓ Self-review your changes to make sure nothing unexpected slipped through ✓ Assign yourself to the PR ✓ Assign one or several reviewer(s) ✓ Once created, link this PR to its corresponding ticket ✓ Acknowledge any changes required to the Wiki --> Co-authored-by: KtorZ <matthias.benkort@gmail.com>
Build failed |
…r for receiving messages
KtorZ
force-pushed
the
KtorZ/1036/daedalus-ipc-race-condition
branch
from
5a2ae78
to
9ff9b25
Compare
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Nov 14, 2019
1037: Fix DaedalusIPC race-condition when sending 'Started' too quickly r=KtorZ a=KtorZ # Issue Number <!-- Put here a reference to the issue this PR relates to and which requirements it tackles --> #1036 # Overview <!-- Detail in a few bullet points the work accomplished in this PR --> - [x] I have artificially reproduced the issue in our mock-daedalus and saw it fails (wait infinitely) - [x] I have added some retry logic to re-send `Started` every second if Daedalus has shown any sign of life. # Comments <!-- Additional comments or screenshots to attach if any --> <!-- Don't forget to: ✓ Self-review your changes to make sure nothing unexpected slipped through ✓ Assign yourself to the PR ✓ Assign one or several reviewer(s) ✓ Once created, link this PR to its corresponding ticket ✓ Acknowledge any changes required to the Wiki --> Co-authored-by: KtorZ <matthias.benkort@gmail.com>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
#1036
Overview
Startedevery second if Daedalus has shown any sign of life.Comments