Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Additional fixes for integration tests on Windows #1029

Merged
merged 12 commits into from
Nov 14, 2019
Merged

Additional fixes for integration tests on Windows #1029

merged 12 commits into from
Nov 14, 2019

Conversation

piotr-iohk
Copy link
Contributor

@piotr-iohk piotr-iohk commented Nov 14, 2019 •
edited by paweljakubas
Loading

Issue Number

Overview

  • I have updated the error message for "Connection refuse" so it is ok for Windows and Linux/Mac (hopefully)
  • Use 'waitForProcess' windows work-around in launcher tests & review filepath to use a platform agnostic separator
  • Use a temporary file as a handle for the LOGGING tests and remove this whole collectStreams convoluted logic :)
  • remove race cond in TRANS_DELETE_05 and remove some expectation also because of this

Comments

@piotr-iohk piotr-iohk self-assigned this Nov 14, 2019
@KtorZ KtorZ changed the title Connection refuse message update for Windows compatibility (PORT tests) Additional fixes for integration tests on Windows Nov 14, 2019
@KtorZ KtorZ force-pushed the piotr/port_tests_on_windows branch from 41be8e8 to 9185ca9 Compare November 14, 2019 13:17
Piotr Stachyra and others added 4 commits November 14, 2019 15:34
@KtorZ
Copy link
Member

KtorZ commented Nov 14, 2019

bors try

iohk-bors bot added a commit that referenced this pull request Nov 14, 2019
@iohk-bors
Try #1029:
cf615e3
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Nov 14, 2019

try

Build failed

@KtorZ
Copy link
Member

KtorZ commented Nov 14, 2019

Just ran into our old friend:

    Failures:
    
      test/integration/Test/Integration/Jormungandr/Scenario/CLI/Server.hs:126:9: 
      1) CLI Specifications, LOGGING - cardano-wallet serve logging [SERIAL], LOGGING - Serve default logs Info
           uncaught exception: IOException of type InvalidArgument
           /tmp/temp-file17942-2: hGetContents: invalid argument (invalid byte sequence)
    
      To rerun use: --match "/CLI Specifications/LOGGING - cardano-wallet serve logging [SERIAL]/LOGGING - Serve default logs Info/"
    
    Randomized with seed 1500817439

https://buildkite.com/input-output-hk/cardano-wallet/builds/3979#051d4d3c-41a8-498a-b76d-91aa2831cd9a

So... disabling the DaedalusIPC tests again in CI :(

@KtorZ
Copy link
Member

KtorZ commented Nov 14, 2019

cc @rvl ☝️

@KtorZ
Copy link
Member

KtorZ commented Nov 14, 2019

bors try

iohk-bors bot added a commit that referenced this pull request Nov 14, 2019
@iohk-bors
Try #1029:
308e188
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Nov 14, 2019

try

Build failed

@KtorZ
Copy link
Member

KtorZ commented Nov 14, 2019

bors try

iohk-bors bot added a commit that referenced this pull request Nov 14, 2019
@iohk-bors
Try #1029:
f46a22b
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Nov 14, 2019

try

Build succeeded

@KtorZ KtorZ force-pushed the piotr/port_tests_on_windows branch from 2431955 to 7bd9bb0 Compare November 14, 2019 16:20
@KtorZ
Copy link
Member

KtorZ commented Nov 14, 2019

bors try

iohk-bors bot added a commit that referenced this pull request Nov 14, 2019
@iohk-bors
Try #1029:
e9a09c4
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Nov 14, 2019

try

Build failed

@KtorZ KtorZ force-pushed the piotr/port_tests_on_windows branch from a87dd70 to 6ca78a3 Compare November 14, 2019 16:52
@KtorZ
Copy link
Member

KtorZ commented Nov 14, 2019

bors r+

iohk-bors bot added a commit that referenced this pull request Nov 14, 2019
@iohk-bors @KtorZ @paweljakubas
Merge #1029
70cb661 
1029: Additional fixes for integration tests on Windows  r=KtorZ a=piotr-iohk

# Issue Number

<!-- Put here a reference to the issue this PR relates to and which requirements it tackles -->


# Overview

<!-- Detail in a few bullet points the work accomplished in this PR -->

- [x] I have updated the error message for "Connection refuse" so it is ok for Windows and Linux/Mac (hopefully)
- [x] Use 'waitForProcess' windows work-around in launcher tests & review filepath to use a platform agnostic separator
- [x] Use a temporary file as a handle for the LOGGING tests and remove this whole `collectStreams` convoluted logic :) 
- [x] remove race cond in TRANS_DELETE_05 and remove some expectation also because of this  

# Comments

<!-- Additional comments or screenshots to attach if any -->

<!-- 
Don't forget to:

 ✓ Self-review your changes to make sure nothing unexpected slipped through
 ✓ Assign yourself to the PR
 ✓ Assign one or several reviewer(s)
 ✓ Once created, link this PR to its corresponding ticket
 ✓ Acknowledge any changes required to the Wiki
-->


Co-authored-by: Piotr Stachyra <piotr.stachyra@iohk.io>
Co-authored-by: KtorZ <matthias.benkort@gmail.com>
Co-authored-by: Pawel Jakubas <pawel.jakubas@iohk.io>
@KtorZ
Copy link
Member

KtorZ commented Nov 14, 2019

Merging ANYWAY to get this being build on master. This .tix file stuff is really REALLY annoying now. I think we need to have a fresh build on master to actually replace the executable available in path that are currently the broken ones from the previous PR.

@KtorZ KtorZ merged commit 11b24ad into master Nov 14, 2019
@KtorZ KtorZ deleted the piotr/port_tests_on_windows branch November 14, 2019 17:19
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Nov 14, 2019

Build failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rvl rvl rvl approved these changes

Assignees

@piotr-iohk piotr-iohk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@piotr-iohk @KtorZ @rvl @paweljakubas