Refactor test for 1004 regression #1010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KtorZ
approved these changes
Nov 12, 2019
| @@ -141,7 +142,8 @@ data TestCase a = TestCase | |||
| spec :: forall t n. (n ~ 'Testnet) => SpecWith (Context t) | |||
| spec = do | |||
| it "Regression #1004 -\ | |||
| \ Incorrect transaction amount reported on pending txs" $ \ctx -> do | |||
| \ Transaction to self shows only fees as a tx amount\ | |||
| \ while both, pending and in_ledger" $ \ctx -> do | |||
| , expectListItemFieldBetween 0 amount (feeMin, feeMax) | ||
| , expectListItemFieldEqual 0 direction Outgoing | ||
| , expectListItemFieldEqual 0 status InLedger | ||
| ] |
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Nov 12, 2019
1003: Attempt to fix intermittent startup issues with Jörmungandr r=KtorZ a=KtorZ # Issue Number <!-- Put here a reference to the issue this PR relates to and which requirements it tackles --> #931 # Overview <!-- Detail in a few bullet points the work accomplished in this PR --> - [x] I have increased the epoch length to give Jörmungandr more time to start before an epoch changes. - [x] I have also changed some hard-coded `/` path separator to use the platform-agnostic version `</>`. # Comments <!-- Additional comments or screenshots to attach if any --> Not sure if this will help, but we can try 🤷♂️ <!-- Don't forget to: ✓ Self-review your changes to make sure nothing unexpected slipped through ✓ Assign yourself to the PR ✓ Assign one or several reviewer(s) ✓ Once created, link this PR to its corresponding ticket ✓ Acknowledge any changes required to the Wiki --> 1010: Refactor test for 1004 regression r=KtorZ a=piotr-iohk # Issue Number #1004 # Overview <!-- Detail in a few bullet points the work accomplished in this PR --> - [ ] I have refactored the script testing #1004 to make it more clear (it was not clear to me until I figured that it is a tx to self address). Added clearer description and additional check for _in_ledger_ tx - [ ] updated `start_node` script # Comments <!-- Additional comments or screenshots to attach if any --> <!-- Don't forget to: ✓ Self-review your changes to make sure nothing unexpected slipped through ✓ Assign yourself to the PR ✓ Assign one or several reviewer(s) ✓ Once created, link this PR to its corresponding ticket ✓ Acknowledge any changes required to the Wiki --> Co-authored-by: KtorZ <matthias.benkort@gmail.com> Co-authored-by: Piotr Stachyra <piotr.stachyra@iohk.io>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
#1004
Overview
start_nodescriptComments