Faililing tests integration tests on Windows #1115
Assignees
Comments
|
Thanks
It would be nice to find out which (failing) tests leave behind the |
|
Edit: updated Failing/Passing after #1125 Failing ❌ : Passing ✔️ : Perhaps those that are now passing were failing due to this unexpected Jormungandr hanging in bg... |
|
That is very plausible @piotr-iohk 🤔 |
|
I had a closer look at the Actually it's not simply a matter of ignoring the exception, as I previously thought. By the time |
iohk-bors bot
added a commit
that referenced
this issue
Dec 6, 2019
1124: Core Benchmark Adjustments r=KtorZ a=KtorZ # Issue Number <!-- Put here a reference to the issue this PR relates to and which requirements it tackles --> #1067 # Overview <!-- Detail in a few bullet points the work accomplished in this PR --> 1/ Use db transactions "correctly" :s .. I noticed that the benchmark where doing a lot of mapM_ (atomically action) instead of atomitically (mapM_ action). The difference is subtle but the later is much faster (one db transaction) and actually, better reflects what the actual code does in the wallet engine. 2/ I've removed some pointless extreme case like trying to insert 1000 checkpoints. We insert at most k/100 + 10 checkpoints, so that's ~30 checkpoints. So, now, the worst case bench is just about inserting 100 checkpoints. Though, as a counterpart, I've increased the max size of the UTxO to make sure they better reflect what we might face. 3/ I've removed the "NBatch" parameter for transactions. We always insert transaction history as one batch (though the internal db engine might do multiple batch, that's irrelevant for the bench setup). 4/ I've added some heavier transaction write with 255 and 255 max inputs / outputs since this is the actual limit of Jörmungandr (which didn't end up using a soft tx limit in the end). # Comments <!-- Additional comments or screenshots to attach if any --> Nightly here: https://buildkite.com/input-output-hk/cardano-wallet-nightly/builds/303 <!-- Don't forget to: ✓ Self-review your changes to make sure nothing unexpected slipped through ✓ Assign yourself to the PR ✓ Assign one or several reviewer(s) ✓ Once created, link this PR to its corresponding ticket ✓ Assign the PR to a corresponding milestone ✓ Acknowledge any changes required to the Wiki --> 1125: Fixing Windows failing tests r=piotr-iohk a=piotr-iohk # Issue Number #1115 # Overview <!-- Detail in a few bullet points the work accomplished in this PR --> - [ ] Fixed `TRANS_EXTERNAL_CREATE_01` and `CLI_VERSION` # Comments <!-- Additional comments or screenshots to attach if any --> <!-- Don't forget to: ✓ Self-review your changes to make sure nothing unexpected slipped through ✓ Assign yourself to the PR ✓ Assign one or several reviewer(s) ✓ Once created, link this PR to its corresponding ticket ✓ Assign the PR to a corresponding milestone ✓ Acknowledge any changes required to the Wiki --> Co-authored-by: KtorZ <matthias.benkort@gmail.com> Co-authored-by: Piotr Stachyra <piotr.stachyra@iohk.io>
iohk-bors bot
added a commit
that referenced
this issue
Dec 6, 2019
1125: Fixing Windows failing tests r=piotr-iohk a=piotr-iohk # Issue Number #1115 # Overview <!-- Detail in a few bullet points the work accomplished in this PR --> - [ ] Fixed `TRANS_EXTERNAL_CREATE_01` and `CLI_VERSION` # Comments <!-- Additional comments or screenshots to attach if any --> <!-- Don't forget to: ✓ Self-review your changes to make sure nothing unexpected slipped through ✓ Assign yourself to the PR ✓ Assign one or several reviewer(s) ✓ Once created, link this PR to its corresponding ticket ✓ Assign the PR to a corresponding milestone ✓ Acknowledge any changes required to the Wiki --> Co-authored-by: Piotr Stachyra <piotr.stachyra@iohk.io>
iohk-bors bot
added a commit
that referenced
this issue
Dec 9, 2019
1116: Estimate fees for joining a stake pool r=KtorZ a=Anviking # Issue Number WB-32: #1094 #1096 (Found it easier to tackle both at once) # Overview Also see commit history, but main points: - [x] Added API endpoint *GET /stake-pools/{stake-pool}/wallets/{wallet}/fee* - [x] Added `feeBalance :: CoinSelection -> Word64`. I re-use `selectCoinsForDelegation` together with `feeBalance` to implement the `joinStakePoolFee` handler. - [x] Integration tests: - STAKE_POOLS_ESTIMATE_FEE_01 - fee matches eventual cost - STAKE_POOLS_ESTIMATE_FEE_02 - empty wallet cannot estimate fee - STAKE_POOLS_ESTIMATE_FEE_03 - can't use byron wallets - STAKE_POOLS_ESTIMATE_FEE_04 - invalid pool and wallet ids <!-- Additional comments or screenshots to attach if any --> <!-- Don't forget to: ✓ Self-review your changes to make sure nothing unexpected slipped through ✓ Assign yourself to the PR ✓ Assign one or several reviewer(s) ✓ Once created, link this PR to its corresponding ticket ✓ Assign the PR to a corresponding milestone ✓ Acknowledge any changes required to the Wiki --> 1149: bump versions to v2019.12.9 r=KtorZ a=KtorZ # Issue Number <!-- Put here a reference to the issue this PR relates to and which requirements it tackles --> N/A # Overview <!-- Detail in a few bullet points the work accomplished in this PR --> - [x] I have bumped versions to v2019.12.9 # Comments <!-- Additional comments or screenshots to attach if any --> Known issues for the upcoming release: - #1115 - #1071 - #961 <!-- Don't forget to: ✓ Self-review your changes to make sure nothing unexpected slipped through ✓ Assign yourself to the PR ✓ Assign one or several reviewer(s) ✓ Once created, link this PR to its corresponding ticket ✓ Assign the PR to a corresponding milestone ✓ Acknowledge any changes required to the Wiki --> Co-authored-by: Johannes Lund <johannes.lund@iohk.io> Co-authored-by: KtorZ <matthias.benkort@gmail.com>
iohk-bors bot
added a commit
that referenced
this issue
Dec 9, 2019
1149: bump versions to v2019.12.9 r=KtorZ a=KtorZ # Issue Number <!-- Put here a reference to the issue this PR relates to and which requirements it tackles --> N/A # Overview <!-- Detail in a few bullet points the work accomplished in this PR --> - [x] I have bumped versions to v2019.12.9 # Comments <!-- Additional comments or screenshots to attach if any --> Known issues for the upcoming release: - #1115 - #1071 - #961 <!-- Don't forget to: ✓ Self-review your changes to make sure nothing unexpected slipped through ✓ Assign yourself to the PR ✓ Assign one or several reviewer(s) ✓ Once created, link this PR to its corresponding ticket ✓ Assign the PR to a corresponding milestone ✓ Acknowledge any changes required to the Wiki --> Co-authored-by: KtorZ <matthias.benkort@gmail.com>
|
Running tests on recent master (https://hydra.iohk.io/build/1552156) and there are only 2 failures: The first one however passes when re-running with |
|
@piotr-iohk are you also able to run all tests at once now or do you still run things one-by-one ? |
|
@KtorZ I've run everything at once. |
27 tasks
iohk-bors bot
added a commit
that referenced
this issue
Jan 13, 2020
1255: Fix LOGGING test on Windows r=piotr-iohk a=piotr-iohk # Issue Number #1115 # Overview - 71c8f30 Fix LOGGING test on Windows - c3e9828 chmod +x for test_scripts # Comments Fixes test: ``` 2) CLI Specifications, LOGGING - cardano-wallet serve logging [SERIAL], LOGGING - Serve shuts down logging correctly "... a lot of logs here..." does not contain "Logging shutdown" ``` which now pass on Windows and Linux. Co-authored-by: Piotr Stachyra <piotr.stachyra@iohk.io> Co-authored-by: Rodney Lorrimar <rodney.lorrimar@iohk.io>
|
Today, after the fix - #1255 - I get such errors on integration tests: However, the other day, I think all tests passed for me. 🤔 Another issue is that after tests are finished - Jormungandr is not killed but left working and logging to the console. |
|
On the latest https://hydra.iohk.io/build/1566747 all integration tests are passing when running standalone: Also unit tests passed for me for core and jormungandr... |
|
@piotr-iohk Shall we close this one then? Perhaps we can now open a new ticket to replace this one about getting the tests to run properly in Hydra? (cc @rvl) |
|
Closing. New issue created for tracking failing tests on Hydra -> #1283. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Context
#703
Test Case
Following 21 tests are failing (after the path issue fix -> #1109):
Also
jormungandr.exe"stays" there and keeps logging to console after the tests are finished...Failure / Counter-example
Resolution
TRANS_EXTERNAL_CREATE_01andCLI_VERSIONQA
The text was updated successfully, but these errors were encountered: