Skip to content

Commit

Permalink
Merge #3097
Browse files Browse the repository at this point in the history
3097: Use Integer instead of Word128 for ghcjs r=jonathanknowles a=hamishmack

The `wide-word` package does not support 32bit platforms like ghcjs.

`@rvl:`
> We really didn't need wide-word in this situation.
> Execution speed or memory usage is not relevant.
> Integer would work just as well.


Co-authored-by: Hamish Mackenzie <Hamish.K.Mackenzie@gmail.com>
Co-authored-by: IOHK <devops+stack-project@iohk.io>
  • Loading branch information
3 people authored Mar 2, 2022
2 parents 56917c2 + cd621d4 commit a3096af
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 5 deletions.
1 change: 0 additions & 1 deletion lib/core/cardano-wallet-core.cabal
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,6 @@ library
, wai
, warp
, warp-tls
, wide-word
, x509
, x509-store
, x509-validation
Expand Down
4 changes: 1 addition & 3 deletions lib/core/src/Control/Monad/Random/Extra.hs
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,6 @@ import Data.Bits
( (.|.) )
import Data.Coerce
( coerce )
import Data.WideWord.Word128
( Word128 (..) )
import Data.Word
( Word64 )
import Data.Word.Odd
Expand Down Expand Up @@ -77,7 +75,7 @@ newtype StdGenSeed = StdGenSeed
deriving (Eq, Bounded, Generic, Ord)
deriving Show via (Quiet StdGenSeed)

type Word127 = OddWord Word128 (Lit 127)
type Word127 = OddWord Integer (Lit 127)

instance ToJSON StdGenSeed where
toJSON = toJSON . Number . fromIntegral . unStdGenSeed
Expand Down
1 change: 0 additions & 1 deletion nix/materialized/stack-nix/cardano-wallet-core.nix

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit a3096af

Please sign in to comment.