Skip to content

feat: ability to inspect drep vote delegation operations. #373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

matiwinnetou
Copy link
Collaborator

No description provided.

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds support for inspecting DRep vote delegation operations and updates related tests and service logic.

  • Introduces a new test enum value for DRep vote delegation.
  • Refactors tests and service methods to incorporate DRep vote delegation while replacing DelegationEntity with PoolDelegationEntity where appropriate.
  • Adds new repository and mapping logic for DRep vote delegation, but several merge conflict markers remain unresolved.

Reviewed Changes

Copilot reviewed 27 out of 27 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
test-data-generator/src/main/java/org/cardanofoundation/rosetta/testgenerator/common/TestTransactionNames.java Added DREP_VOTE_DELEGATION enum for test scenarios.
api/src/test/java/org/cardanofoundation/rosetta/api/search/controller/SearchControllerTest.java Introduced a new mock (networkService) to support test setups.
api/src/test/java/org/cardanofoundation/rosetta/api/block/service/LedgerBlockServiceImplTest.java Updated test methods to include a new empty collection for drep vote delegations.
api/src/test/java/org/cardanofoundation/rosetta/api/block/service/LedgerBlockServiceImplIntTest.java Changed DelegationEntity references to PoolDelegationEntity to match updated logic.
api/src/test/java/org/cardanofoundation/rosetta/api/TransactionsTestData.java Adjusted file path formatting using String.format.
api/src/main/java/org/cardanofoundation/rosetta/common/exception/ExceptionFactory.java Revised error messages and formatting (merge conflict markers remain).
api/src/main/java/org/cardanofoundation/rosetta/api/block/service/LedgerBlockServiceImpl.java Refactored to support DRep vote delegation; unresolved merge conflict markers are present.
api/src/main/java/org/cardanofoundation/rosetta/api/block/model/repository/PoolDelegationRepository.java Added new repository interface for pool delegations.
api/src/main/java/org/cardanofoundation/rosetta/api/block/model/repository/DelegationRepository.java Removed obsolete delegation repository in favor of pool delegation.
api/src/main/java/org/cardanofoundation/rosetta/api/block/model/repository/DRepVoteDelegationRepository.java Added new repository interface for DRep vote delegation.
api/src/main/java/org/cardanofoundation/rosetta/api/block/mapper/TransactionMapper.java Updated mapping to handle DRep vote delegation entities.
api/src/main/java/org/cardanofoundation/rosetta/api/account/service/AccountServiceImpl.java Adjusted import ordering and minor formatting changes.
api/src/main/java/org/cardanofoundation/rosetta/RosettaApiApplication.java Updated annotation ordering and added transaction management.

@matiwinnetou matiwinnetou changed the base branch from main to develop March 26, 2025 19:53
@matiwinnetou matiwinnetou force-pushed the drep-rosetta-operations branch 5 times, most recently from d3838d2 to 095327d Compare March 28, 2025 10:01
@cardano-foundation cardano-foundation deleted a comment from Copilot AI Mar 28, 2025
@matiwinnetou matiwinnetou force-pushed the drep-rosetta-operations branch 5 times, most recently from be9e9b8 to b434cd5 Compare March 30, 2025 10:54
@matiwinnetou matiwinnetou added this to the 1.2.7 milestone Apr 1, 2025
@matiwinnetou matiwinnetou force-pushed the drep-rosetta-operations branch 9 times, most recently from 2bcdcdb to d9f8f02 Compare April 2, 2025 09:22
@matiwinnetou matiwinnetou force-pushed the drep-rosetta-operations branch from d9f8f02 to c0f01e7 Compare April 2, 2025 12:31
@matiwinnetou matiwinnetou added this to the 1.3.0 milestone Apr 9, 2025
Base automatically changed from develop to main April 11, 2025 12:29
@matiwinnetou matiwinnetou force-pushed the drep-rosetta-operations branch 3 times, most recently from c36993a to 5d8d19e Compare April 16, 2025 08:28
@matiwinnetou matiwinnetou changed the base branch from main to develop April 16, 2025 08:28
@matiwinnetou matiwinnetou force-pushed the drep-rosetta-operations branch from 5d8d19e to b4b2c4f Compare April 16, 2025 09:40
@matiwinnetou matiwinnetou force-pushed the drep-rosetta-operations branch 15 times, most recently from d4e6b30 to bb0adb5 Compare April 24, 2025 15:20
@matiwinnetou matiwinnetou marked this pull request as ready for review April 24, 2025 15:21
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant