-
Notifications
You must be signed in to change notification settings - Fork 8
feat: ability to inspect drep vote delegation operations. #373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
matiwinnetou
wants to merge
1
commit into
develop
Choose a base branch
from
drep-rosetta-operations
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Adds support for inspecting DRep vote delegation operations and updates related tests and service logic.
- Introduces a new test enum value for DRep vote delegation.
- Refactors tests and service methods to incorporate DRep vote delegation while replacing DelegationEntity with PoolDelegationEntity where appropriate.
- Adds new repository and mapping logic for DRep vote delegation, but several merge conflict markers remain unresolved.
Reviewed Changes
Copilot reviewed 27 out of 27 changed files in this pull request and generated 2 comments.
Show a summary per file
File | Description |
---|---|
test-data-generator/src/main/java/org/cardanofoundation/rosetta/testgenerator/common/TestTransactionNames.java | Added DREP_VOTE_DELEGATION enum for test scenarios. |
api/src/test/java/org/cardanofoundation/rosetta/api/search/controller/SearchControllerTest.java | Introduced a new mock (networkService) to support test setups. |
api/src/test/java/org/cardanofoundation/rosetta/api/block/service/LedgerBlockServiceImplTest.java | Updated test methods to include a new empty collection for drep vote delegations. |
api/src/test/java/org/cardanofoundation/rosetta/api/block/service/LedgerBlockServiceImplIntTest.java | Changed DelegationEntity references to PoolDelegationEntity to match updated logic. |
api/src/test/java/org/cardanofoundation/rosetta/api/TransactionsTestData.java | Adjusted file path formatting using String.format. |
api/src/main/java/org/cardanofoundation/rosetta/common/exception/ExceptionFactory.java | Revised error messages and formatting (merge conflict markers remain). |
api/src/main/java/org/cardanofoundation/rosetta/api/block/service/LedgerBlockServiceImpl.java | Refactored to support DRep vote delegation; unresolved merge conflict markers are present. |
api/src/main/java/org/cardanofoundation/rosetta/api/block/model/repository/PoolDelegationRepository.java | Added new repository interface for pool delegations. |
api/src/main/java/org/cardanofoundation/rosetta/api/block/model/repository/DelegationRepository.java | Removed obsolete delegation repository in favor of pool delegation. |
api/src/main/java/org/cardanofoundation/rosetta/api/block/model/repository/DRepVoteDelegationRepository.java | Added new repository interface for DRep vote delegation. |
api/src/main/java/org/cardanofoundation/rosetta/api/block/mapper/TransactionMapper.java | Updated mapping to handle DRep vote delegation entities. |
api/src/main/java/org/cardanofoundation/rosetta/api/account/service/AccountServiceImpl.java | Adjusted import ordering and minor formatting changes. |
api/src/main/java/org/cardanofoundation/rosetta/RosettaApiApplication.java | Updated annotation ordering and added transaction management. |
api/src/main/java/org/cardanofoundation/rosetta/common/exception/ExceptionFactory.java
Outdated
Show resolved
Hide resolved
d3838d2
to
095327d
Compare
be9e9b8
to
b434cd5
Compare
2bcdcdb
to
d9f8f02
Compare
d9f8f02
to
c0f01e7
Compare
c36993a
to
5d8d19e
Compare
5d8d19e
to
b4b2c4f
Compare
d4e6b30
to
bb0adb5
Compare
|
bb0adb5
to
151b663
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.