Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CIP-0068 | Clarify label prefixes #471

Merged
merged 4 commits into from
Mar 11, 2023
Merged

CIP-0068 | Clarify label prefixes #471

merged 4 commits into from
Mar 11, 2023

Conversation

mateusap1
Copy link
Contributor

By reading the CIP-0068 and trying to implement it myself I was convinced the asset name should literally be prefixed with the label (100) and not with the implementation suggested by CIP-0067, there was no reference whatsoever to the correct label convention as far as I am aware and this PR tries to make things more clear for future developers attempting to implement CIP-0068 on their own.

@alessandrokonrad
Copy link
Contributor

Thanks @mateusap1. This was indeed not very obvious. It wasn't clear back then how the labels will actually look like and then it was forgotten to specify them correctly in CIP-0068. However I think as a general convention and for convenience e.g. (100) could be a high level representation of an actual CIP-0067 label.

@mateusap1
Copy link
Contributor Author

@alessandrokonrad Thanks for your quick reply.

However I think as a general convention and for convenience e.g. (100) could be a high level representation of an actual CIP-0067 label.

I made a comment at the end of the "Labels" section trying to pass that idea. It reads as follows

For simplicity purposes, the document will use the label (100) or (<label>) in the following documentation, but understand it should follow the CIP-0067 specification.

Let me know if this satisfies your concern or if you still have any suggestions / issues.

Copy link
Collaborator

@rphair rphair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks to me like the added text clarifies what was posted in comments so far, so I'd approve this as long as @alessandrokonrad you think it satisfies your latest comment & @SmaugPool and other interested parties have no objections.

@rphair rphair added the Update Adds content or significantly reworks an existing proposal label Mar 5, 2023
@rphair rphair changed the title CIP-0068 | Make document more clear concerning label prefixes CIP-0068 | Clarify label prefixes Mar 5, 2023
@alessandrokonrad
Copy link
Contributor

@rphair yes this LGTM

@KtorZ KtorZ merged commit c028a53 into cardano-foundation:master Mar 11, 2023
Ryun1 pushed a commit to Ryun1/CIPs that referenced this pull request Nov 17, 2023
* added section clarifying labels

* made wording less repetitive

* add reference to CIP 67

* remove repeated references
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Update Adds content or significantly reworks an existing proposal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants