Vote endpoints now return proposal hash and voting hashes, added cert… #297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…_index param to proposal votes endpoint, spec updates
Description
Vote list endpoints now return proposal_tx_hash of the proposal and vote_tx_hash of the vote, and blocktime has been corrected to be that of the latter. One of the endpoints had cert_index parameter in implementation but was missing from API specs. Ordering changed from block time to tx id as can have multiple voting transactions within same block in theory.
Where should the reviewer start?
Motivation and context
Which issue it fixes?
How has this been tested?