-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make carbonifer available as Go library #41
Conversation
Thanks a lot @Joffref for this first contribution ❤️ That's much appreciated !
The viper part does not look that ugly, I'll have a look later to see if we can find a nicer way Again, thanks! |
Signed-off-by: Mathis Joffre <mariusjoffre@gmail.com>
Hey @obierlaire, I've made few changes on the PR, based on your comments. Hope it will be good this time, let me know if there is something to modify in it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you need to rebase once #47 will be merged
I agree 👍 Waiting to the update on your side |
#47 merged, you can rebase your branch |
Signed-off-by: Mathis Joffre <mariusjoffre@gmail.com>
Nice one ! It will be better like this 👍 |
Closes: #40
Thanks to this PR
GetEstimationFromInstanceType()
,GetEstimation()
andGetResource()
will be available as part of carbonifer Go Lib.Note to the maintainers: I had struggle with the way viper is used to import data, I make an ugly workaround. I'm open to your suggestion on this point in order to find the best way to patch this. 😄