Add the firebase site framework to carbon-lang. #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm mainly thinking to keep it here because changes relevant to the push of carbon-lang.dev are in the same repo.
EricWF
approved these changes
May 6, 2020
Instead of using listMembers and looking for the ID, instead use list to translate the ID to a user, then getMembership to look for a member.
EricWF
reviewed
May 6, 2020
|
LGTM (again). |
This was referenced Apr 22, 2022
This was referenced May 11, 2022
This was referenced May 25, 2022
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 27, 2024
This only sets the symbolizer for our more used targets; not sure if there's a great way to set it everywhere (I suppose I could try wrapping cc_binary etc rules if there's a strong preference). There is a downside here, symbolizing a fastbuild crash seems to take about 3s. Not sure if there's a good way to get a faster llvm-symbolizer execution...? I tried running with the new LLVM update without the LLVM_SYMBOLIZER_PATH, and it looks like that's insufficient. With the settings, I now get readable crashes: ``` #9 0x000055dc007d1724 void Carbon::Internal::CheckFail<Carbon::TemplateString<5>{"FATAL"}, Carbon::TemplateString<27>{"toolchain/driver/driver.cpp"}, 84, Carbon::TemplateString<0>{}, Carbon::TemplateString<3>{"err"}>() (/usr/local/google/home/jperkins/.cache/bazel/_bazel_jperkins/85deb7d9d96f7e0e80b42618a55969d7/sandbox/linux-sandbox/9383/execroot/_main/bazel-out/k8-fastbuild/bin/toolchain/testing/file_test.runfiles/_main/toolchain/testing/file_test+0x2894724) ``` Note the LLVM update is for llvm/llvm-project#109021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm mainly thinking to keep it here because changes relevant to the push of carbon-lang.dev are in the same repo.