Track the instruction used to name the type and constraint in an impl. #4368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is necessary in order to have access to the specific versions of their constant values in a generic impl.
josh11b
reviewed
Oct 3, 2024
There was a problem hiding this comment.
Can we make a test showing that we now report the correct source location for a type where we couldn't before?
(Probably not in this PR.) Some of the new references are to instructions with bare 'loc' names. It would help readability if we could get descriptive instruction names in more cases.
josh11b
reviewed
Oct 3, 2024
josh11b
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is necessary in order to have access to the specific versions of their constant values in a generic impl.
Stub out impl deduction.