Use more compact storage for impl lookup buckets. #4351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
zygoloid
force-pushed
the
toolchain-lookup-bucket
branch
from
be3e988
to
3b8650f
Compare
jonmeow
approved these changes
Sep 27, 2024
toolchain/sem_ir/impl.h
Outdated
| // An ID of either a single impl or a lookup bucket. | ||
| class ImplOrLookupBucketId : public IdBase { | ||
| public: | ||
| using IdBase::IdBase; |
There was a problem hiding this comment.
Had you considered making the constructor private in order to emphasize use of the factory functions?
| @@ -57,22 +57,110 @@ struct Impl : public EntityWithParamsBase, | |||
| // A collection of `Impl`s, which can be accessed by the self type and | |||
| // constraint implemented. | |||
| class ImplStore { | |||
| private: | |||
| // An ID of either a single impl or a lookup bucket. | |||
| class ImplOrLookupBucketId : public IdBase { | |||
There was a problem hiding this comment.
Abstractly, we have a couple other things which have TinyPtrVector-like TODOs. Particularly NameScope's extended_scopes had seemed similar, but this approach won't work for it (I think it'd need to own the vector). I think this approach is fine, but I wanted to note this because I don't think this approach would work directly in other use-cases; I'm not sure precisely where the trade-offs stand to try to get something generally applicable.
If the bucket is of size zero or one, which is expected to be the common case, then store it directly. For the remaining cases, use a side table of lookup buckets.
Co-authored-by: Jon Ross-Perkins <jperkins@google.com>
zygoloid
force-pushed
the
toolchain-lookup-bucket
branch
from
eead722
to
78e319d
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the bucket is of size zero or one, which is expected to be the common
case, then store it directly. For the remaining cases, use a side table
of lookup buckets.