Don't substitute into the targeted instructions of an associated constant. #4342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've split this PR into three commits: the first adds the test and shows the old behavior (with the CHECK disabled), the second fixes the bug, and the third updates the test to show new new behavior (and re-enables the CHECK). This should hopefully give a better idea of what this PR is fixing. |
geoffromer
reviewed
Sep 26, 2024
toolchain/sem_ir/ids.h
Outdated
| @@ -86,6 +86,20 @@ constexpr InstId InstId::Invalid = InstId(InvalidIndex); | |||
| InstId::ForBuiltin(BuiltinInstKind::Name); | |||
| #include "toolchain/sem_ir/builtin_inst_kind.def" | |||
|
|
|||
| // An ID of an instruction that is referenced absolutely within a typed | |||
There was a problem hiding this comment.
The phrasing of this comment makes it sound kind of like "absoluteness" is a property of the inst itself, but based on the code, I gather it's actually a property of the ID. In other words, in principle you could have an AbsoluteInstId and an InstId that refer to the same inst. Is that right?
There was a problem hiding this comment.
Yes, that's right. I've updated the comment to try to make this clearer.
geoffromer
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an instruction makes an absolute reference to another instruction, such as when
assoc_constrefers to the declaration of the associated constant in an interface, substitution into that instruction should not substitute into the referenced instruction.Mark the corresponding
InstIdfields in the typed instructions as being absolute by giving them a distinct ID type thatSubstdoesn't substitute into. This formation of unnecessarily complicated SemIR that could in some cases lead to a CHECK failure when printing formatted SemIR because the same instruction ends up in multiple scopes.