Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse support for where operator #4275

Merged
merged 89 commits into from
Sep 11, 2024
Merged

Conversation

josh11b
Copy link
Contributor

@josh11b josh11b commented Sep 4, 2024

Includes support for the impls, =, and == requirement operators to the right of a where, but and to allow multiple requirements is still a TODO.

Copy link
Contributor

@zygoloid zygoloid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

toolchain/parse/handle_requirement.cpp Outdated Show resolved Hide resolved
toolchain/parse/handle_requirement.cpp Show resolved Hide resolved
toolchain/parse/handle_requirement.h Outdated Show resolved Hide resolved
toolchain/parse/precedence.cpp Outdated Show resolved Hide resolved
toolchain/parse/typed_nodes.h Outdated Show resolved Hide resolved
toolchain/parse/typed_nodes.h Show resolved Hide resolved
toolchain/parse/typed_nodes.h Outdated Show resolved Hide resolved
toolchain/parse/typed_nodes.h Outdated Show resolved Hide resolved
@josh11b
Copy link
Contributor Author

josh11b commented Sep 10, 2024

Improved the tests, and now fixing up after merging.

@zygoloid zygoloid added this pull request to the merge queue Sep 11, 2024
Merged via the queue into carbon-language:trunk with commit c33c9a0 Sep 11, 2024
8 checks passed
@josh11b josh11b deleted the where branch September 11, 2024 04:31
github-merge-queue bot pushed a commit that referenced this pull request Sep 11, 2024
…y `and` (#4298)

Follow on to #4275 that added `where` parse support.

---------

Co-authored-by: Josh L <josh11b@users.noreply.github.com>
Co-authored-by: Richard Smith <richard@metafoo.co.uk>
github-merge-queue bot pushed a commit that referenced this pull request Sep 12, 2024
Implements
[TODO](https://github.com/carbon-language/carbon-lang/pull/4275/files#r1751000646)
introduced in #4275 . Note that this enforces the restriction
syntactically in parse, following the
[design](https://github.com/carbon-language/carbon-lang/blob/trunk/docs/design/generics/details.md#rewrite-constraints).

---------

Co-authored-by: Josh L <josh11b@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants