Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raw identifier syntax #3797

Merged

Conversation

jonmeow
Copy link
Contributor

@jonmeow jonmeow commented Mar 19, 2024

We want to support legacy identifiers that overlap with new keywords (for example, base). This is being called "raw identifier syntax" using r#<identifier>, and is based on Rust.

Note this proposal is derived from Proposal #17: Lexical conventions.

Co-authored-by: zygoloid richard@metafoo.co.uk

@jonmeow jonmeow added the proposal A proposal label Mar 19, 2024
@jonmeow jonmeow force-pushed the proposal-raw-identifier-synta branch from e74b2fa to e3c02cc Compare March 19, 2024 22:17
@jonmeow jonmeow force-pushed the proposal-raw-identifier-synta branch 2 times, most recently from 5d75586 to 1c86143 Compare March 19, 2024 23:22
@jonmeow jonmeow force-pushed the proposal-raw-identifier-synta branch from 9daa9c4 to 89e829c Compare March 20, 2024 23:44
@jonmeow jonmeow force-pushed the proposal-raw-identifier-synta branch from 89e829c to b290484 Compare March 28, 2024 18:27
@jonmeow jonmeow force-pushed the proposal-raw-identifier-synta branch 5 times, most recently from 581b482 to 998f131 Compare April 1, 2024 19:58
@jonmeow jonmeow marked this pull request as ready for review April 1, 2024 19:59
@github-actions github-actions bot added the proposal rfc Proposal with request-for-comment sent out label Apr 1, 2024
@github-actions github-actions bot requested a review from zygoloid April 1, 2024 19:59
proposals/p3797.md Outdated Show resolved Hide resolved
Co-authored-by: Carbon Infra Bot <carbon-external-infra@google.com>
Copy link
Contributor

@zygoloid zygoloid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

proposals/p3797.md Outdated Show resolved Hide resolved
@jonmeow jonmeow force-pushed the proposal-raw-identifier-synta branch from 1467bdf to d7c481b Compare April 3, 2024 22:40
@jonmeow jonmeow force-pushed the proposal-raw-identifier-synta branch from 65af1ca to db8602d Compare April 12, 2024 05:12
@jonmeow jonmeow force-pushed the proposal-raw-identifier-synta branch from db8602d to 06ab1c2 Compare April 29, 2024 15:22
Copy link
Contributor

@zygoloid zygoloid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No concerns identified, and this matches the toolchain. Approved on behalf of leads.

@zygoloid zygoloid added this pull request to the merge queue May 1, 2024
Merged via the queue into carbon-language:trunk with commit 6907870 May 1, 2024
7 checks passed
@jonmeow jonmeow deleted the proposal-raw-identifier-synta branch May 1, 2024 22:36
chandlerc pushed a commit to chandlerc/carbon-lang that referenced this pull request May 2, 2024
We want to support legacy identifiers that overlap with new keywords
(for example, `base`). This is being called "raw identifier syntax"
using `r#<identifier>`, and is based on
[Rust](https://doc.rust-lang.org/reference/identifiers.html).

Note this proposal is derived from [Proposal carbon-language#17: Lexical
conventions](carbon-language#17).

Co-authored-by: zygoloid <richard@metafoo.co.uk>

---------

Co-authored-by: Carbon Infra Bot <carbon-external-infra@google.com>
CJ-Johnson pushed a commit to CJ-Johnson/carbon-lang that referenced this pull request May 23, 2024
We want to support legacy identifiers that overlap with new keywords
(for example, `base`). This is being called "raw identifier syntax"
using `r#<identifier>`, and is based on
[Rust](https://doc.rust-lang.org/reference/identifiers.html).

Note this proposal is derived from [Proposal carbon-language#17: Lexical
conventions](carbon-language#17).

Co-authored-by: zygoloid <richard@metafoo.co.uk>

---------

Co-authored-by: Carbon Infra Bot <carbon-external-infra@google.com>
github-merge-queue bot pushed a commit that referenced this pull request Aug 19, 2024
Feature approved in #3797

---------

Co-authored-by: Chandler Carruth <chandlerc@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
proposal rfc Proposal with request-for-comment sent out proposal A proposal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants