-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Design updates for #2015 numeric type literal syntax #2410
Design updates for #2015 numeric type literal syntax #2410
Conversation
Thanks for the design updates! Adding @josh11b to help with review here as he helped review the original proposal. |
…teral-syntax' of https://github.com/avicorp/carbon-lang into Design-updates-for-carbon-language#2015-numeric-type-literal-syntax
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please follow the instructions at https://github.com/carbon-language/carbon-lang/blob/trunk/docs/project/contribution_tools.md to set up pre-commit
and prettier
for auto-formatting.
I talked with @zygoloid about how we should organize the docs, and he had the idea, which I like, that:
The path forward would be to move this content into |
@josh11b, how can we continue with the PR? |
@zygoloid @josh11b Thanks for the Suggestions. I am struggling to decide what scope should be defined in the overview section of literal expressions. In other languages, I have seen that all literal expressions are grouped together in the same document. However, here, we have split numeric floats and strings under Lexical Conventions. What do you think about what I wrote in the overview? |
Edit numeric literal design for the literal type proposal and add reference where #2015 was mentioned.
Closes #2159