Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design updates for #2015 numeric type literal syntax #2410

Conversation

avicorp
Copy link
Contributor

@avicorp avicorp commented Nov 17, 2022

Edit numeric literal design for the literal type proposal and add reference where #2015 was mentioned.

Closes #2159

@chandlerc
Copy link
Contributor

Thanks for the design updates! Adding @josh11b to help with review here as he helped review the original proposal.

docs/design/README.md Outdated Show resolved Hide resolved
docs/design/README.md Outdated Show resolved Hide resolved
docs/design/README.md Outdated Show resolved Hide resolved
docs/design/README.md Outdated Show resolved Hide resolved
docs/design/numeric_literals.md Outdated Show resolved Hide resolved
@Pixep Pixep added the design update Action items to update docs/design based on approved proposals and leads decisions label Nov 18, 2022
@avicorp avicorp requested review from josh11b and removed request for jonmeow November 22, 2022 10:16
Copy link
Contributor

@josh11b josh11b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please follow the instructions at https://github.com/carbon-language/carbon-lang/blob/trunk/docs/project/contribution_tools.md to set up pre-commit and prettier for auto-formatting.

@avicorp avicorp requested a review from josh11b November 24, 2022 15:26
@josh11b
Copy link
Contributor

josh11b commented Dec 2, 2022

I talked with @zygoloid about how we should organize the docs, and he had the idea, which I like, that:

  • eventually the docs/design/expressions/ section describes all kinds of expressions, which would include numeric type literals
  • it would be reasonable to have a single document that covers all kinds of literals, especially if we don't have much to say about them, and only break out specific kinds of literals to their own documents if there are enough details to warrant that (more than 3 pages of text, say)

The path forward would be to move this content into docs/design/expressions/literals.md and link to it from docs/design/expressions/README.md; if literals.md gets too big we can think about splitting it up then.

@avicorp
Copy link
Contributor Author

avicorp commented Dec 8, 2022

@josh11b, how can we continue with the PR?

docs/design/expressions/README.md Outdated Show resolved Hide resolved
docs/design/expressions/literals.md Outdated Show resolved Hide resolved
docs/design/expressions/literals.md Outdated Show resolved Hide resolved
docs/design/expressions/literals.md Outdated Show resolved Hide resolved
docs/design/expressions/literals.md Outdated Show resolved Hide resolved
docs/design/expressions/literals.md Show resolved Hide resolved
docs/design/expressions/literals.md Outdated Show resolved Hide resolved
docs/design/expressions/literals.md Outdated Show resolved Hide resolved
docs/design/expressions/literals.md Outdated Show resolved Hide resolved
docs/design/expressions/README.md Outdated Show resolved Hide resolved
docs/design/expressions/README.md Outdated Show resolved Hide resolved
docs/design/README.md Outdated Show resolved Hide resolved
docs/design/README.md Outdated Show resolved Hide resolved
docs/design/expressions/README.md Outdated Show resolved Hide resolved
@avicorp
Copy link
Contributor Author

avicorp commented Dec 9, 2022

@zygoloid @josh11b Thanks for the Suggestions.

I am struggling to decide what scope should be defined in the overview section of literal expressions. In other languages, I have seen that all literal expressions are grouped together in the same document. However, here, we have split numeric floats and strings under Lexical Conventions. What do you think about what I wrote in the overview?

@avicorp avicorp requested review from josh11b and zygoloid and removed request for josh11b and zygoloid December 9, 2022 11:05
@avicorp avicorp requested review from zygoloid and removed request for josh11b December 9, 2022 11:05
@josh11b josh11b merged commit dd2f7d7 into carbon-language:trunk Dec 9, 2022
zygoloid pushed a commit that referenced this pull request Dec 14, 2022
…and update (#2459)

Follow-on to change #2410 which created the `expressions/literals.md` home for literal expressions. Incorporates the decision in #2113 to address a TODO.
@chandlerc chandlerc added the documentation An issue or proposed change to our documentation label Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design update Action items to update docs/design based on approved proposals and leads decisions documentation An issue or proposed change to our documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need design updates for #2015 numeric type literal syntax
5 participants