Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify package in the README.md to mark unreviewed ideas as provisional. #2324

Merged
merged 5 commits into from
Oct 20, 2022

Conversation

jonmeow
Copy link
Contributor

@jonmeow jonmeow commented Oct 20, 2022

I've filed #2323 to track the design idea for package, and #2001 already tracked import, but these should be explicitly marked as provisional.

Comment on lines 2155 to 2158
> **Note:** This is provisional, designs for making the package name optional
> have not been through the proposal process yet. See
> [#2323](https://github.com/carbon-language/carbon-lang/issues/2323).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way to phrase this so it is clear that, while it hasn't been through the proposal process, it was decided in #1136 ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would just add that issue to the tracking one Jon filed, not sure it's worth tracking here as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adjusted to reference #2001 for tracking.

Copy link
Contributor

@chandlerc chandlerc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM fwiw.

@jonmeow jonmeow merged commit 4601a9c into carbon-language:trunk Oct 20, 2022
@jonmeow jonmeow deleted the code branch October 20, 2022 21:51
@chandlerc chandlerc added the documentation An issue or proposed change to our documentation label Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation An issue or proposed change to our documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants