Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dropdown): add overflow styles to menu options #2206

Merged
merged 9 commits into from
Mar 26, 2019
Merged

fix(dropdown): add overflow styles to menu options #2206

merged 9 commits into from
Mar 26, 2019

Conversation

emyarod
Copy link
Member

@emyarod emyarod commented Mar 26, 2019 •
edited
Loading

Closes #2205

This PR adds overflow styles to dropdown menu options to match the changes to the trigger button changes in #2203

Changelog

New

  • text overflow styles for dropdown menu options
  • docs examples to show text overflow behavior in dropdowns and listboxes

Changed

  • reduce inline listbox menu side margins to match
  • revert flex item menu options to block display for text-overflow styles

Testing / Reviewing

check dropdown and listbox menus for regressions

@emyarod emyarod added this to the v10-update milestone Mar 26, 2019
@emyarod emyarod requested a review from laurenmrice March 26, 2019 14:50
@netlify
Copy link

netlify bot commented Mar 26, 2019 •
edited
Loading

Deploy preview for the-carbon-components ready!

Built with commit d37bebc

https://deploy-preview-2206--the-carbon-components.netlify.com

@emyarod emyarod force-pushed the 2205-listbox-menu-option-overflow-incorrect-spacing branch from f79894a to 2183e7b Compare March 26, 2019 14:55
@emyarod emyarod mentioned this pull request Mar 26, 2019
Merged
alisonjoseph
alisonjoseph approved these changes Mar 26, 2019
View reviewed changes
Copy link
Member

@alisonjoseph alisonjoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! thanks

laurenmrice
laurenmrice requested changes Mar 26, 2019
View reviewed changes
Copy link
Member

@laurenmrice laurenmrice left a comment •
edited by emyarod
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes:

  • For all variants of listbox, the dropdown drawer in the preview is down too far
    Screen Shot 2019-03-26 at 11 25 11 AM

  • For Inline Listbox, when clicking an option in a dropdown, the option text jumps to the right.
    Screen Shot 2019-03-26 at 11 26 11 AM

@emyarod
Copy link
Member Author

emyarod commented Mar 26, 2019

the gap between the trigger button and the drawer could only seen in stable Firefox. In Firefox Nightly, the issue was not present (bringing it in line with Chrome and Safari's behavior), but I've added a style rule that should address it in stable Firefox now

@emyarod emyarod requested a review from laurenmrice March 26, 2019 17:30
laurenmrice
laurenmrice approved these changes Mar 26, 2019
View reviewed changes
Copy link
Member

@laurenmrice laurenmrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@emyarod emyarod mentioned this pull request Mar 26, 2019
Merged
@emyarod emyarod modified the milestones: v10-update, v10.0-rc1 Mar 26, 2019
@emyarod emyarod merged commit 7a5e057 into carbon-design-system:master Mar 26, 2019
@emyarod emyarod deleted the 2205-listbox-menu-option-overflow-incorrect-spacing branch March 26, 2019 18:00
@carbon-bot
Copy link
Contributor

🎉 This PR is included in version 9.90.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@emyarod emyarod mentioned this pull request Mar 26, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laurenmrice laurenmrice laurenmrice approved these changes

@joshblack joshblack joshblack approved these changes

@alisonjoseph alisonjoseph alisonjoseph approved these changes

Assignees
No one assigned
Labels
status: one more review 👀 status: ready for review 👀 status: visual review 🔍
Projects
None yet
Milestone
v10.0-rc1
Development

Successfully merging this pull request may close these issues.
5 participants
@emyarod @carbon-bot @alisonjoseph @joshblack @laurenmrice