fix: fixes a11y violation in ExpandedSearch #18203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #18203 +/- ##
=======================================
Coverage 84.16% 84.16%
=======================================
Files 404 404
Lines 14350 14350
Branches 4599 4619 +20
=======================================
Hits 12077 12077
+ Misses 2112 2111 -1
- Partials 161 162 +1 ☔ View full report in Codecov by Sentry. |
tay1orjones
approved these changes
Dec 9, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
The content of this pull request will be made available as part of our next release. For the full schedule of upcoming releases, check out our Release Radar page. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #18202
Correctly associate the label with the div(role=button)
Changed
aria-labelledby={onExpand ? searchId : undefined}
Removed
aria-labelledby={onExpand ? uniqueId : undefined}
Testing / Reviewing
go to storybook, open expanded search, run Accessibility Checker with latest deployment and 13Nov24 deployment
Verify no violations