fix(datepicker): adds Optional chaining #18046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #18046 +/- ##
==========================================
+ Coverage 82.10% 82.15% +0.04%
==========================================
Files 404 404
Lines 14107 14107
Branches 4426 4426
==========================================
+ Hits 11582 11589 +7
+ Misses 2363 2356 -7
Partials 162 162 ☔ View full report in Codecov by Sentry. |
riddhybansal
approved these changes
Nov 13, 2024
preetibansalui
approved these changes
Nov 13, 2024
|
The content of this pull request will be made available as part of our next release. For the full schedule of upcoming releases, check out our Release Radar page. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #17794
adds Optional chaining to fix Cannot read properties of undefined error
Changelog
Changed
Adds
?.operator before callingsetHoursandtoStringfunctionsTesting / Reviewing
Open the DatePicker component configured for a date range.
Select a start and end date.
Clear the entire input field for end date.
Move the focus to another input field (start date) or component
verify to errors in console
Uploading Screen Recording 2024-11-12 at 14.50.07.mov…