feat(number-input): new decorator prop #18020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #18020 +/- ##
==========================================
+ Coverage 81.92% 81.94% +0.01%
==========================================
Files 404 404
Lines 14095 14107 +12
Branches 4413 4430 +17
==========================================
+ Hits 11548 11560 +12
Misses 2384 2384
Partials 163 163 ☔ View full report in Codecov by Sentry. |
riddhybansal
approved these changes
Nov 11, 2024
riddhybansal
requested changes
Nov 11, 2024
riddhybansal
approved these changes
Nov 12, 2024
alisonjoseph
approved these changes
Nov 12, 2024
Merged
via the queue into
carbon-design-system:main
with commit Nov 12, 2024
ce8f5e3
40 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #18004
Updates numper-input to include new decorator prop
Changelog
New
Changed
Testing / Reviewing
Check dropdown with AILabel storybook and form with AILabel storybook (numberInput & fluid numberInput)
TODO: