test: adding unit tests for ProgressIndicatorSkeleton #17829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mariat Sebastian <mariatsebastian189@gmail.com>
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17829 +/- ##
==========================================
+ Coverage 80.45% 80.49% +0.04%
==========================================
Files 406 406
Lines 14041 14041
Branches 4347 4347
==========================================
+ Hits 11296 11302 +6
+ Misses 2579 2573 -6
Partials 166 166 ☔ View full report in Codecov by Sentry. |
guidari
approved these changes
Oct 23, 2024
kennylam
approved these changes
Oct 25, 2024
|
Hi @kennylam , @alisonjoseph |
Merged
via the queue into
carbon-design-system:main
with commit Oct 28, 2024
706c84a
40 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #17472
This PR adds unit tests for the ProgressIndicatorSkeleton component to ensure its proper rendering and functionality. The The tests ensure that the skeleton renders with the appropriate class names, accommodates custom class names etc.
Changelog
Changed
Testing / Reviewing
Additional Notes