Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Feature Flag out of Experimental #17806

Merged
merged 11 commits into from
Oct 23, 2024

Conversation

guidari
Copy link
Contributor

@guidari guidari commented Oct 18, 2024

Closes #17762

In this PR it was moved all Feature Flag stories out of experimental into their respective components folder under a folder called Feature Flag.

In a few cases you will notice that was deleted a few stories if the exampless could be seen only in one stories.

Changelog

Changed

  • Moved all Feature Flag stories to their respective component's folder.

Testing / Reviewing

  • Make sure the stories deleted make sense by comparing with the current storybook

@guidari guidari requested a review from a team as a code owner October 18, 2024 19:34
Copy link

netlify bot commented Oct 18, 2024

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit 9eb1917
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-web-components/deploys/6718f85a676939000848bebb
😎 Deploy Preview https://deploy-preview-17806--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@guidari guidari requested a review from annawen1 October 18, 2024 19:34
Copy link

netlify bot commented Oct 18, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 9eb1917
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/6718f85a10c2d50008c57fd4
😎 Deploy Preview https://deploy-preview-17806--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 18, 2024

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 9eb1917
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/6718f85a3e788a00082b2b70
😎 Deploy Preview https://deploy-preview-17806--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@alisonjoseph alisonjoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These all LGTM, would we be able to move the "Flag details" page to be at the top the same way overview is? Or should we just name that page overview also to match?

Related, do we have an issue to update the website live demos once this is live? I think Tile,Tag and StrutcturedList will need to get updated with the new urls.

@annawen1
Copy link
Member

These all LGTM, would we be able to move the "Flag details" page to be at the top the same way overview is? Or should we just name that page overview also to match?

I agree, if we can have the "Flag details" page above the feature flag stories that would be ideal!

Copy link

codecov bot commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.14%. Comparing base (b543079) to head (9eb1917).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #17806      +/-   ##
==========================================
- Coverage   80.16%   80.14%   -0.03%     
==========================================
  Files         406      406              
  Lines       14029    14029              
  Branches     4343     4395      +52     
==========================================
- Hits        11246    11243       -3     
- Misses       2617     2619       +2     
- Partials      166      167       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@guidari guidari enabled auto-merge October 23, 2024 13:22
@guidari guidari added this pull request to the merge queue Oct 23, 2024
Merged via the queue into carbon-design-system:main with commit bdc5573 Oct 23, 2024
26 of 27 checks passed
@guidari guidari deleted the 17762-feature-flag branch October 23, 2024 14:41
@carbon-automation
Copy link
Contributor

Hey there! v11.69.0 was just released that references this issue/PR.

irfadkp pushed a commit to irfadkp/carbon that referenced this pull request Oct 24, 2024
* feat: adding feature flag item to stable

* feat: added combobox floating styles

* fix: imported all dynamic floating styles to stable

* feat: added remaning feature flags

* fix: fixed a tile and overflow paths in avt tests

* test: fixed tests

* fix: removed parameter from main.js

* fix: fixed naming

* fix: moved flag details to the top level
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FeatureFlags: Refactor story and doc locations
3 participants