-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move Feature Flag out of Experimental #17806
Move Feature Flag out of Experimental #17806
Conversation
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These all LGTM, would we be able to move the "Flag details" page to be at the top the same way overview is? Or should we just name that page overview also to match?
Related, do we have an issue to update the website live demos once this is live? I think Tile,Tag and StrutcturedList will need to get updated with the new urls.
I agree, if we can have the "Flag details" page above the feature flag stories that would be ideal! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17806 +/- ##
==========================================
- Coverage 80.16% 80.14% -0.03%
==========================================
Files 406 406
Lines 14029 14029
Branches 4343 4395 +52
==========================================
- Hits 11246 11243 -3
- Misses 2617 2619 +2
- Partials 166 167 +1 ☔ View full report in Codecov by Sentry. |
bdc5573
Hey there! v11.69.0 was just released that references this issue/PR. |
* feat: adding feature flag item to stable * feat: added combobox floating styles * fix: imported all dynamic floating styles to stable * feat: added remaning feature flags * fix: fixed a tile and overflow paths in avt tests * test: fixed tests * fix: removed parameter from main.js * fix: fixed naming * fix: moved flag details to the top level
Closes #17762
In this PR it was moved all Feature Flag stories out of experimental into their respective components folder under a folder called Feature Flag.
In a few cases you will notice that was deleted a few stories if the exampless could be seen only in one stories.
Changelog
Changed
Testing / Reviewing