Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Unit-test]: File Uploader #17791

Merged

Conversation

divya-281
Copy link
Contributor

@divya-281 divya-281 commented Oct 18, 2024

Increases test coverage for file uploader
#17483

@divya-281 divya-281 requested a review from a team as a code owner October 18, 2024 06:13
@divya-281 divya-281 requested review from kennylam and guidari October 18, 2024 06:13
Copy link

netlify bot commented Oct 18, 2024

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit db6f1de
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-web-components/deploys/6711fc984dd34400086a170e
😎 Deploy Preview https://deploy-preview-17791--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 18, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit db6f1de
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/6711fc98d4a1810008ccd1b4
😎 Deploy Preview https://deploy-preview-17791--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 18, 2024

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit db6f1de
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/6711fc989ae12900083cc37f
😎 Deploy Preview https://deploy-preview-17791--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Oct 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.74%. Comparing base (4312ae4) to head (db6f1de).
Report is 26 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #17791      +/-   ##
==========================================
+ Coverage   79.72%   79.74%   +0.02%     
==========================================
  Files         406      406              
  Lines       14012    14012              
  Branches     4333     4385      +52     
==========================================
+ Hits        11171    11174       +3     
+ Misses       2676     2672       -4     
- Partials      165      166       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@guidari guidari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pulled down locally to check the coverage and looks good to me!!
Thanks for doing that!

@kennylam kennylam added this pull request to the merge queue Oct 23, 2024
Merged via the queue into carbon-design-system:main with commit a7f0464 Oct 23, 2024
40 checks passed
@carbon-automation
Copy link
Contributor

Hey there! v11.69.0 was just released that references this issue/PR.

irfadkp pushed a commit to irfadkp/carbon that referenced this pull request Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants