-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: pagination nav adjacent double ellipses #17779
fix: pagination nav adjacent double ellipses #17779
Conversation
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17779 +/- ##
==========================================
+ Coverage 79.86% 79.93% +0.07%
==========================================
Files 406 406
Lines 14012 14012
Branches 4333 4381 +48
==========================================
+ Hits 11190 11200 +10
+ Misses 2657 2647 -10
Partials 165 165 ☔ View full report in Codecov by Sentry. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Hey @riddhybansal I guess the best way to test that is to replicate the behaviour we did together while testing the fix.
I'm happy to pair on that if needed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
dcf227f
to
5932df9
Compare
Yeah , Got what you are saying .. Added the test case for more clear testing !! This is indirectly testing the overflow menu behaviour in the pagination nav also. Please check and do let me know !! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! LGTM 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
df8787e
Closes #17628
Fix pagination nav adjacent ellipses
Changelog
New
Testing / Reviewing
Render with props itemsShown = 4, totalItems = something >= 10
Select a page from the ellipses
Select the first page
There should not be adjacent elleipses