Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: increase coverage on FilterableMultiSelect #17763

Merged
merged 10 commits into from
Nov 4, 2024
Merged

Conversation

Gururajj77
Copy link
Contributor

@Gururajj77 Gururajj77 commented Oct 16, 2024

Closes #17479

adding tests to increase coverage

Changelog

New

  • added new test cases covering various stuff related to downshift

Testing / Reviewing

  • pull the PR down
  • run the command yarn test FilterableMultiSelect-test.js --coverage
  • check that coverage is above 85

@Gururajj77 Gururajj77 changed the title test: adding comment to run codecov test: increase coverage on FilterableMultiSelect Oct 16, 2024
Copy link

netlify bot commented Oct 16, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 24e84e5
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/6728621d36794900086743eb
😎 Deploy Preview https://deploy-preview-17763--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 16, 2024

Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit 24e84e5
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/6728621d8c53d80008973629
😎 Deploy Preview https://deploy-preview-17763--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.59%. Comparing base (c300d45) to head (24e84e5).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #17763      +/-   ##
==========================================
+ Coverage   81.16%   81.59%   +0.43%     
==========================================
  Files         406      406              
  Lines       14047    14047              
  Branches     4355     4355              
==========================================
+ Hits        11401    11462      +61     
+ Misses       2480     2422      -58     
+ Partials      166      163       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

netlify bot commented Oct 17, 2024

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit 24e84e5
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-web-components/deploys/6728621dc3d9700008c9a46c
😎 Deploy Preview https://deploy-preview-17763--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Gururajj77 Gururajj77 marked this pull request as ready for review October 17, 2024 11:20
@Gururajj77 Gururajj77 requested a review from a team as a code owner October 17, 2024 11:20
Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

Copy link
Member

@tay1orjones tay1orjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, that is a ton of new tests!

@tay1orjones
Copy link
Member

percy was failing but I just updated with latest from main which I believe should fix it.

@Gururajj77 Gururajj77 enabled auto-merge November 4, 2024 05:56
@Gururajj77 Gururajj77 added this pull request to the merge queue Nov 4, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 4, 2024
@Gururajj77 Gururajj77 added this pull request to the merge queue Nov 4, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 4, 2024
@Gururajj77 Gururajj77 added this pull request to the merge queue Nov 4, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 4, 2024
@Gururajj77 Gururajj77 added this pull request to the merge queue Nov 4, 2024
Merged via the queue into main with commit 506e6a3 Nov 4, 2024
40 checks passed
@Gururajj77 Gururajj77 deleted the fmselect-test branch November 4, 2024 15:21
Copy link
Contributor

github-actions bot commented Nov 4, 2024

The content of this pull request will be made available as part of our next release. For the full schedule of upcoming releases, check out our Release Radar page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Increase FilterableMultiSelect unit test coverage
3 participants