-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: increase coverage on FilterableMultiSelect
#17763
Conversation
FilterableMultiSelect
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17763 +/- ##
==========================================
+ Coverage 81.16% 81.59% +0.43%
==========================================
Files 406 406
Lines 14047 14047
Branches 4355 4355
==========================================
+ Hits 11401 11462 +61
+ Misses 2480 2422 -58
+ Partials 166 163 -3 ☔ View full report in Codecov by Sentry. |
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, that is a ton of new tests!
percy was failing but I just updated with latest from main which I believe should fix it. |
The content of this pull request will be made available as part of our next release. For the full schedule of upcoming releases, check out our Release Radar page. |
Closes #17479
adding tests to increase coverage
Changelog
New
Testing / Reviewing
yarn test FilterableMultiSelect-test.js --coverage