-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: updated multiselect docs with select all feature details and usage #17758
Conversation
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Co-authored-by: kennylam <909118+kennylam@users.noreply.github.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17758 +/- ##
==========================================
- Coverage 80.15% 80.14% -0.02%
==========================================
Files 406 406
Lines 14011 14029 +18
Branches 4380 4391 +11
==========================================
+ Hits 11231 11243 +12
- Misses 2613 2620 +7
+ Partials 167 166 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would change the wording a little, also might be nice to add to the nav at the top of the storybook docs also, could easily be missed otherwise at the bottom of the page.
Co-authored-by: Alison Joseph <alison.joseph@us.ibm.com>
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Co-authored-by: Alison Joseph <alison.joseph@us.ibm.com>
The content of this pull request will be made available as part of our next release. For the full schedule of upcoming releases, check out our Release Radar page. |
Hey there! v11.69.0 was just released that references this issue/PR. |
…age (carbon-design-system#17758) * docs: updated multiselect docs with select all feature usage * Update packages/react/src/components/MultiSelect/MultiSelect.mdx Co-authored-by: kennylam <909118+kennylam@users.noreply.github.com> * Update packages/react/src/components/MultiSelect/MultiSelect.mdx Co-authored-by: Alison Joseph <alison.joseph@us.ibm.com> * Update packages/react/src/components/MultiSelect/MultiSelect.mdx Co-authored-by: Alison Joseph <alison.joseph@us.ibm.com> * docs: added select all to navigation --------- Co-authored-by: kennylam <909118+kennylam@users.noreply.github.com> Co-authored-by: Alison Joseph <alison.joseph@us.ibm.com>
Closes #17689
Added documentation about select all overview and usage in the Multiselect's storybook over page
Changelog
New
Testing / Reviewing
go to deploy preview, check the multiselect component overview page, scroll down and see the select all documentation in the page