Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: updated multiselect docs with select all feature details and usage #17758

Merged
merged 7 commits into from
Oct 23, 2024

Conversation

Gururajj77
Copy link
Contributor

Closes #17689

Added documentation about select all overview and usage in the Multiselect's storybook over page

Changelog

New

  • select all feature documentation

Testing / Reviewing

go to deploy preview, check the multiselect component overview page, scroll down and see the select all documentation in the page

Copy link

netlify bot commented Oct 16, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit c746a70
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/6717a8982d424100080e5295
😎 Deploy Preview https://deploy-preview-17758--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 16, 2024

Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit c746a70
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/6717a898d0b8d5000869e6a7
😎 Deploy Preview https://deploy-preview-17758--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Co-authored-by: kennylam <909118+kennylam@users.noreply.github.com>
Copy link

codecov bot commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.14%. Comparing base (e48f5e6) to head (c746a70).
Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #17758      +/-   ##
==========================================
- Coverage   80.15%   80.14%   -0.02%     
==========================================
  Files         406      406              
  Lines       14011    14029      +18     
  Branches     4380     4391      +11     
==========================================
+ Hits        11231    11243      +12     
- Misses       2613     2620       +7     
+ Partials      167      166       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@alisonjoseph alisonjoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would change the wording a little, also might be nice to add to the nav at the top of the storybook docs also, could easily be missed otherwise at the bottom of the page.

packages/react/src/components/MultiSelect/MultiSelect.mdx Outdated Show resolved Hide resolved
packages/react/src/components/MultiSelect/MultiSelect.mdx Outdated Show resolved Hide resolved
Co-authored-by: Alison Joseph <alison.joseph@us.ibm.com>
Copy link

netlify bot commented Oct 18, 2024

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit c746a70
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-web-components/deploys/6717a8982be1d900085622a4
😎 Deploy Preview https://deploy-preview-17758--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Co-authored-by: Alison Joseph <alison.joseph@us.ibm.com>
@alisonjoseph alisonjoseph added this pull request to the merge queue Oct 23, 2024
Merged via the queue into main with commit dbc173d Oct 23, 2024
39 of 40 checks passed
@alisonjoseph alisonjoseph deleted the multiselect-selectall-docs branch October 23, 2024 15:45
Copy link
Contributor

The content of this pull request will be made available as part of our next release. For the full schedule of upcoming releases, check out our Release Radar page.

@carbon-automation
Copy link
Contributor

Hey there! v11.69.0 was just released that references this issue/PR.

irfadkp pushed a commit to irfadkp/carbon that referenced this pull request Oct 24, 2024
…age (carbon-design-system#17758)

* docs: updated multiselect docs with select all feature usage

* Update packages/react/src/components/MultiSelect/MultiSelect.mdx

Co-authored-by: kennylam <909118+kennylam@users.noreply.github.com>

* Update packages/react/src/components/MultiSelect/MultiSelect.mdx

Co-authored-by: Alison Joseph <alison.joseph@us.ibm.com>

* Update packages/react/src/components/MultiSelect/MultiSelect.mdx

Co-authored-by: Alison Joseph <alison.joseph@us.ibm.com>

* docs: added select all to navigation

---------

Co-authored-by: kennylam <909118+kennylam@users.noreply.github.com>
Co-authored-by: Alison Joseph <alison.joseph@us.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[story]: Add the selectAll prop usage for multiselect
3 participants