Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed duplicate onChange #17754

Merged
merged 5 commits into from
Oct 17, 2024
Merged

Conversation

guidari
Copy link
Contributor

@guidari guidari commented Oct 15, 2024

Closes #17736

Removed duplicated onChange.

It is already being called here:

  const [selection, setSelection] = useControllableState({
    value: selectedItem,
    onChange,
    defaultValue: defaultSelectedItem,
  });

Changelog

Testing / Reviewing

  • Added Test story

  • Remove Test story

@guidari guidari requested a review from a team as a code owner October 15, 2024 17:46
@guidari guidari requested review from emyarod and annawen1 October 15, 2024 17:46
Copy link

netlify bot commented Oct 15, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit db8f66c
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/671140c662276100097d6b18
😎 Deploy Preview https://deploy-preview-17754--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 15, 2024

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit db8f66c
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/671140c6c0aed80008f66dbd
😎 Deploy Preview https://deploy-preview-17754--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@2nikhiltom 2nikhiltom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good ! Thanks for adding the test 🎉

Copy link
Member

@tay1orjones tay1orjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once the test story is removed

Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

Copy link

netlify bot commented Oct 17, 2024

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit db8f66c
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-web-components/deploys/671140c6a303a80008be8eab
😎 Deploy Preview https://deploy-preview-17754--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@guidari guidari enabled auto-merge October 17, 2024 16:54
Copy link

codecov bot commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.63%. Comparing base (a7d18f1) to head (db8f66c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #17754      +/-   ##
==========================================
+ Coverage   79.55%   79.63%   +0.07%     
==========================================
  Files         406      406              
  Lines       14014    14012       -2     
  Branches     4382     4381       -1     
==========================================
+ Hits        11149    11158       +9     
+ Misses       2700     2689      -11     
  Partials      165      165              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@guidari guidari added this pull request to the merge queue Oct 17, 2024
Merged via the queue into carbon-design-system:main with commit 1232b5e Oct 17, 2024
40 checks passed
@guidari guidari deleted the 17736-menuitem branch October 17, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: The <MenuItemRadioGroup> component fires the onChange callback function twice
6 participants