Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(ai-label/pagination-skeleton): increase coverage #17748

Conversation

ariellalgilmore
Copy link
Member

Closes #17495
Closes #17500

Increase coverage for AILabel (slug) and pagination skeleton

Changelog

Changed

  • increased coverage

Testing / Reviewing

check codecov

@ariellalgilmore ariellalgilmore requested a review from a team as a code owner October 15, 2024 15:51
Copy link

netlify bot commented Oct 15, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit aff0154
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/670e8f9ea056730008eedafa
😎 Deploy Preview https://deploy-preview-17748--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 15, 2024

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit aff0154
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/670e8f9e1000320007418a8c
😎 Deploy Preview https://deploy-preview-17748--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Oct 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.44%. Comparing base (98b7c28) to head (aff0154).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #17748      +/-   ##
==========================================
+ Coverage   79.33%   79.44%   +0.11%     
==========================================
  Files         406      406              
  Lines       14019    14019              
  Branches     4336     4384      +48     
==========================================
+ Hits        11122    11138      +16     
+ Misses       2732     2715      -17     
- Partials      165      166       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@2nikhiltom 2nikhiltom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🎉

@annawen1 annawen1 added this pull request to the merge queue Oct 16, 2024
Merged via the queue into carbon-design-system:main with commit 1c34943 Oct 16, 2024
36 checks passed
@ariellalgilmore ariellalgilmore deleted the test/ai-label-pagination-increase-coverage branch October 16, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Increase Slug unit test coverage Increase Pagination.Skeleton unit test coverage
3 participants