Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: link overview page is not loading #17710

Conversation

preetibansalui
Copy link
Contributor

Closes #17709

link overview page is not loading

Changed

The LinkStories import statement was missing.

Testing / Reviewing

  1. Go to Storybook > Link > Overview
  2. It should load as expected.

Copy link

netlify bot commented Oct 10, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 922e8cc
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/6707ade8b9545900087ba937
😎 Deploy Preview https://deploy-preview-17710--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 10, 2024

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 922e8cc
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/6707ade80fc4ad0008689e5f
😎 Deploy Preview https://deploy-preview-17710--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 10, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 9756c4f
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/6707adf4f5c35100082b6639
😎 Deploy Preview https://deploy-preview-17710--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 10, 2024

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 9756c4f
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/6707adf46df95c0009ca300d
😎 Deploy Preview https://deploy-preview-17710--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Oct 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.33%. Comparing base (694e71f) to head (9756c4f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #17710   +/-   ##
=======================================
  Coverage   78.33%   78.33%           
=======================================
  Files         408      408           
  Lines       14015    14015           
  Branches     4344     4372   +28     
=======================================
  Hits        10979    10979           
- Misses       2867     2868    +1     
+ Partials      169      168    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@guidari guidari added this pull request to the merge queue Oct 10, 2024
Merged via the queue into carbon-design-system:main with commit 8ec84a4 Oct 10, 2024
36 checks passed
annawen1 pushed a commit to annawen1/carbon that referenced this pull request Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Link story overview page not loading
3 participants