Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add Index.ts to Checkbox Group #17708

Merged
merged 2 commits into from
Oct 14, 2024

Conversation

2nikhiltom
Copy link
Contributor

@2nikhiltom 2nikhiltom commented Oct 10, 2024

Closes #17693

converts Index.js to Index.tsx

Changelog

export new interfaces

Testing / Reviewing

Verify the errors are thrown in console
functionally is intact

Copy link

netlify bot commented Oct 10, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit cd4cbb0
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/6707a8e9d924ac00082c89eb
😎 Deploy Preview https://deploy-preview-17708--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 10, 2024

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit cd4cbb0
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/6707a8e97907920008dda3a1
😎 Deploy Preview https://deploy-preview-17708--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 10, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit bd57c5d
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/6707a9247907920008dda3bb
😎 Deploy Preview https://deploy-preview-17708--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@2nikhiltom 2nikhiltom marked this pull request as ready for review October 10, 2024 10:26
@2nikhiltom 2nikhiltom requested a review from a team as a code owner October 10, 2024 10:26
Copy link

netlify bot commented Oct 10, 2024

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit bd57c5d
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/6707a924d924ac00082c8a0c
😎 Deploy Preview https://deploy-preview-17708--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Oct 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.33%. Comparing base (694e71f) to head (bd57c5d).
Report is 22 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #17708   +/-   ##
=======================================
  Coverage   78.33%   78.33%           
=======================================
  Files         408      408           
  Lines       14015    14015           
  Branches     4344     4344           
=======================================
  Hits        10979    10979           
  Misses       2867     2867           
  Partials      169      169           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@tay1orjones tay1orjones added this pull request to the merge queue Oct 11, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 11, 2024
@kennylam kennylam added this pull request to the merge queue Oct 14, 2024
Merged via the queue into carbon-design-system:main with commit 0c39d8f Oct 14, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Checkbox group (missing index.ts)
5 participants