Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(pagination): add unit tests for user actions and external updates #17649

Merged
merged 3 commits into from
Oct 14, 2024

Conversation

ychavoya
Copy link
Contributor

@ychavoya ychavoya commented Oct 3, 2024

Closes #17496

Added unit tests to increase the coverage of the Pagination component

Changelog

New

  • Added unit tests for Pagination related to user actions (when users click or select something)
  • Added unit tests for Pagination related to external actions (when the props are updated externally)

See coverage in main:

Screenshot 2024-10-03 at 14 37 47

Versus this PR:

Screenshot 2024-10-03 at 14 35 13

Testing / Reviewing

  • Unit tests should pass

@ychavoya ychavoya requested a review from a team as a code owner October 3, 2024 20:48
Copy link

netlify bot commented Oct 3, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit e06a9bb
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/670917b33004160008b8ac7c
😎 Deploy Preview https://deploy-preview-17649--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 3, 2024

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit e06a9bb
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/670917b30cd3ba00083c7470
😎 Deploy Preview https://deploy-preview-17649--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Oct 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.17%. Comparing base (993fb9c) to head (e06a9bb).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #17649      +/-   ##
==========================================
+ Coverage   78.96%   79.17%   +0.21%     
==========================================
  Files         408      408              
  Lines       14020    14020              
  Branches     4381     4377       -4     
==========================================
+ Hits        11071    11101      +30     
+ Misses       2782     2752      -30     
  Partials      167      167              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kennylam kennylam added this pull request to the merge queue Oct 14, 2024
Merged via the queue into carbon-design-system:main with commit badbac2 Oct 14, 2024
36 checks passed
@ychavoya ychavoya deleted the pagination-coverage branch October 18, 2024 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Increase Pagination unit test coverage
4 participants