fix(TreeNode): preserve nested node expand state #17630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17630 +/- ##
==========================================
- Coverage 77.07% 77.07% -0.01%
==========================================
Files 409 409
Lines 14021 14019 -2
Branches 4327 4325 -2
==========================================
- Hits 10807 10805 -2
Misses 3043 3043
Partials 171 171 ☔ View full report in Codecov by Sentry. |
emyarod
force-pushed
the
17221-fix/treeview-nested-node-open-state
branch
from
3ece9ee to
2918b76
Compare
tay1orjones
approved these changes
Oct 7, 2024
kennylam
approved these changes
Oct 10, 2024
Merged
via the queue into
carbon-design-system:main
with commit Oct 10, 2024
af1cd1b
22 of 23 checks passed
annawen1
pushed a commit
to annawen1/carbon
that referenced
this pull request
Oct 11, 2024
…m#17630) * fix(TreeNode): preserve nested node expand state * fix(TreeView): prevent focus on hidden child nodes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #17221
This PR updates the rendering logic of parent tree nodes. The nodes are no longer removed from the DOM when upstream nodes are collapsed so the expansion state of nested parent nodes is preserved
Changelog
Changed
Testing / Reviewing
confirm that expanded state of nested parent nodes remains even when its own parent nodes are collapsed/expanded