Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FileUploaderDropContainer): resolve click handler error #17568

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(FileUploaderDropContainer): resolve click handler error #17568

wants to merge 1 commit into from

Conversation

emyarod
Copy link
Member

@emyarod emyarod commented Sep 25, 2024 •
edited
Loading

Closes #17393

This PR updates the FileUploaderDropContainer's click handler to be the expected type of string rather than null

Changelog

Changed

  • evt.target.value type from null to empty string

@netlify Netlify
Copy link

netlify bot commented Sep 25, 2024

✅ Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 864a770
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/66f40730d3e07c00086af712
😎 Deploy Preview https://deploy-preview-17568--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@emyarod emyarod marked this pull request as ready for review September 25, 2024 12:57
@emyarod emyarod requested a review from a team as a code owner September 25, 2024 12:57
@netlify Netlify
Copy link

netlify bot commented Sep 25, 2024

✅ Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit 864a770
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/66f4073043e733000803119f
😎 Deploy Preview https://deploy-preview-17568--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@riddhybansal riddhybansal riddhybansal approved these changes

@alisonjoseph alisonjoseph Awaiting requested review from alisonjoseph alisonjoseph is a code owner automatically assigned from carbon-design-system/developers-system-reviewers

@annawen1 annawen1 Awaiting requested review from annawen1 annawen1 is a code owner automatically assigned from carbon-design-system/developers-system-reviewers

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Setting an HTMLInputElement's value to null
2 participants
@emyarod @riddhybansal