fix(styles): update border-block-end to use $border-subtle-01 #17548
Conversation
|
All contributors have signed the DCO. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
I have read the DCO document and I hereby sign the DCO. |
| @@ -205,7 +205,7 @@ | |||
|
|
|||
| .#{$prefix}--data-table td, | |||
| .#{$prefix}--data-table tbody th { | |||
| border-block-end: 1px solid $border-subtle; | |||
| border-block-end: 1px solid $border-subtle-01; | |||
There was a problem hiding this comment.
Similar to this PR, additional selectors/styles are needed to ensure the token is updated appropriately. .#{$prefix}--layer-two, .#{$prefix}--layer-three, etc.
There was a problem hiding this comment.
Without this update the cells will not respond at all to being placed on another layer and will be "locked" to the layer 01 style. There's a bit more detail about this on the website
There was a problem hiding this comment.
@tay1orjones I have updated the changes according to your suggestion.
Closes #17454
Updated the
border-block-endof each element in the table rows.Changelog
Changed
border-block-end: 1px solid $border-subtle;toborder-block-end: 1px solid $border-subtle-01;Testing / Reviewing
Navigate to the DataTable component's playground story.
Review the styling of the
<td>elements in the table rows that use theborder-block-endproperty, and ensure the values are applied correctly and consistently.