-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added tests for FluidTimePicker #17541
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17541 +/- ##
==========================================
+ Coverage 76.95% 77.01% +0.05%
==========================================
Files 408 408
Lines 13979 13979
Branches 4291 4291
==========================================
+ Hits 10758 10766 +8
+ Misses 3048 3042 -6
+ Partials 173 171 -2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks awesome! Just one small thing
</FluidTimePicker> | ||
); | ||
|
||
fireEvent.click(screen.getByRole('textbox')); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could this use userEvent
instead? It more realistically simulates the interaction, see here
Closes #17516
Added tests for FluiTimePicker
Testing / Reviewing