Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(v11): remove StructuredListInput onChange deprecation #17530

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

tay1orjones
Copy link
Member

This updates the migration guide to reflect the removal of the onChange deprecation

Context

  • In v10 StructuredListInput did not actually use or call onChange at all, so we deprecated it for removal in early builds of v11.
  • Later on as we continued work on v11, we did a large a11y refactor of the Structured List components and added the onChange call, making it work.
  • We initially missed/forgot to remove the deprecation warning, but it has since been removed.

Related: #14254

Changelog

Changed

  • update v11.md to reflect current status of onChange StructuredListInput API

Testing / Reviewing

  • Check my grammar

@tay1orjones tay1orjones requested a review from a team as a code owner September 19, 2024 18:57
Copy link

netlify bot commented Sep 19, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 1c98be0
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/66f7011a5fcaf600081b2cc2
😎 Deploy Preview https://deploy-preview-17530--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Sep 19, 2024

Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit 1c98be0
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/66f7011abd006a0008797008
😎 Deploy Preview https://deploy-preview-17530--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Sep 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.03%. Comparing base (5020449) to head (1c98be0).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #17530   +/-   ##
=======================================
  Coverage   77.03%   77.03%           
=======================================
  Files         408      408           
  Lines       13993    13993           
  Branches     4321     4349   +28     
=======================================
  Hits        10779    10779           
  Misses       3041     3041           
  Partials      173      173           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants