-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: refactor and fix controlled combobox #17527
base: main
Are you sure you want to change the base?
Conversation
* Refactor code related to controlled combobox for simplicity. * Update ComboBox when selectedItem prop changes externally. * Call onChange when combobox is cleared or updated. * Unit tests for these cases. * Storybook example for fully controlled component.
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17527 +/- ##
=======================================
Coverage 76.95% 76.96%
=======================================
Files 408 408
Lines 13979 13981 +2
Branches 4343 4339 -4
=======================================
+ Hits 10758 10760 +2
Misses 3047 3047
Partials 174 174 ☔ View full report in Codecov by Sentry. |
Closes #16565
Refactor and bug fixes for controlled combobox
Changelog
Changed