Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(tests): skip flaky tests - menu avt, slider onDrag #17427

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

tay1orjones
Copy link
Member

These tests continue to intermittently fail despite efforts to fix them. They're impeding valid PRs status checks and causing the merge queue to fail and remove multiple PRs.

I've added a new section to #16319 to make sure we fix these.

Changelog

Removed

  • Menu-test.avt.e2e.js:25:3 › @avt Menu › @avt-keyboard-nav Menu
  • Slider › behaves as expected - Two Handle Slider Component API › Error handling, expected behavior from event handlers › gracefully tolerates empty event passed to _onDrag

Testing / Reviewing

  • Has anyone else seen flaky tests in addition to these?

@tay1orjones tay1orjones requested a review from a team as a code owner September 12, 2024 14:27
@tay1orjones tay1orjones self-assigned this Sep 12, 2024
Copy link

netlify bot commented Sep 12, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit fc688c9
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/66e2fa6f8d4a6e0008b07711
😎 Deploy Preview https://deploy-preview-17427--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Sep 12, 2024

Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit fc688c9
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/66e2fa6f22b48b0008637c00
😎 Deploy Preview https://deploy-preview-17427--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Sep 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.82%. Comparing base (a6f1b23) to head (fc688c9).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #17427   +/-   ##
=======================================
  Coverage   76.82%   76.82%           
=======================================
  Files         408      408           
  Lines       13966    13966           
  Branches     4336     4340    +4     
=======================================
  Hits        10730    10730           
  Misses       3062     3062           
  Partials      174      174           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tay1orjones tay1orjones added this pull request to the merge queue Sep 12, 2024
Merged via the queue into carbon-design-system:main with commit 5fcb5c2 Sep 12, 2024
36 checks passed
@tay1orjones tay1orjones deleted the kill-flaky-tests branch September 12, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants