fix(accordion): add transition styles back #17418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17418 +/- ##
=======================================
Coverage 77.07% 77.07%
=======================================
Files 409 409
Lines 14021 14021
Branches 4355 4307 -48
=======================================
Hits 10807 10807
- Misses 3043 3044 +1
+ Partials 171 170 -1 ☔ View full report in Codecov by Sentry. |
ariellalgilmore
added
status: one more review 👀
and removed
status: ready for review 👀
labels
kennylam
approved these changes
Oct 14, 2024
Merged
via the queue into
carbon-design-system:main
with commit Oct 14, 2024
4a7d935
36 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #17197
This fixes a regression that happened when #17120 was merged in to remove items from the dom when the accordion was closed. The issue with that was you can't animate/transition between display none and block. This PR uses @starting-style along with allow-discrete to be able to transition between display block. It currently has support in most major browsers, with partial support in Firefox (it will transition to display none but not from display none), this doesn't break anything and is an improvement from the current state of no transition at all.
Changelog
Testing / Reviewing
Check accordion story and make sure it transitions as expected in Chrome, check with keyboard and ensure that the buttons inside the test accordion item aren't accessible when the accordion is closed.