Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(notification): rename StaticNotification to Callout #17376

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

tay1orjones
Copy link
Member

@tay1orjones tay1orjones commented Sep 6, 2024

Closes #17375

Related carbon-design-system/carbon-website#4218, carbon-design-system/carbon-website#4243

Changelog

New

  • A new codemod to transform StaticNotification usages to Callout

Changed

  • Renamed StaticNotification to Callout and ensure either name can be used to ease the transition
  • Added tests to ensure StaticNotification and Callout naming both work
  • Add deprecation notice that includes instructions on how to run the codemod
  • Update docs and stories to reflect the Callout name

Testing / Reviewing

  • Check the storybook to ensure Callout stuff all works as expected
  • The codemod is ran against the test fixtures in CI, but you can validate the codemod works locally if you'd like.
  • Review the docs changes, ensure they make sense

Copy link

netlify bot commented Sep 6, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 4c583ca
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/66f702ce0f1c970008246ac6
😎 Deploy Preview https://deploy-preview-17376--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Sep 6, 2024

Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit 4c583ca
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/66f702ce3e0f760008c1420b
😎 Deploy Preview https://deploy-preview-17376--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Sep 27, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 77.13%. Comparing base (5020449) to head (4c583ca).

Files with missing lines Patch % Lines
packages/upgrade/src/upgrades.js 0.00% 5 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #17376      +/-   ##
==========================================
+ Coverage   77.03%   77.13%   +0.09%     
==========================================
  Files         408      408              
  Lines       13993    14006      +13     
  Branches     4321     4357      +36     
==========================================
+ Hits        10779    10803      +24     
+ Misses       3041     3032       -9     
+ Partials      173      171       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 🚦 In Review
Development

Successfully merging this pull request may close these issues.

[Callout] Rename StaticNotification to Callout
1 participant