Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update dependency downshift to v9 #17231

Merged
merged 21 commits into from
Nov 12, 2024
Merged

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Aug 21, 2024

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
downshift (source) 8.5.0 -> 9.0.8 age adoption passing confidence

Warning

Some dependencies could not be looked up. Check the Dependency Dashboard for more information.


Release Notes

downshift-js/downshift (downshift)

v9.0.8

Compare Source

Bug Fixes

v9.0.7

Compare Source

Bug Fixes

v9.0.6

Compare Source

Bug Fixes

v9.0.5

Compare Source

Bug Fixes

v9.0.4

Compare Source

Bug Fixes

v9.0.3

Compare Source

Bug Fixes

v9.0.2

Compare Source

Bug Fixes

v9.0.1

Compare Source

Bug Fixes

v9.0.0

Compare Source

Features
BREAKING CHANGES
  • Release Downshift v9.

Why:
Release the changes in:

Closes https://github.com/downshift-js/downshift/issues/1322.
Closes https://github.com/downshift-js/downshift/issues/1244.
Closes https://github.com/downshift-js/downshift/issues/1227
Closes https://github.com/downshift-js/downshift/issues/1225.

How:
Merged the PRs in this branch.

Checklist:

  • Documentation
  • Tests
  • TypeScript Types
  • Flow Types
  • Ready to be merged

Configuration

📅 Schedule: Branch creation - "after 10pm every weekday,before 5am every weekday,every weekend" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Never, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot requested a review from a team as a code owner August 21, 2024 04:46
@renovate renovate bot requested review from tay1orjones and annawen1 August 21, 2024 04:46
Copy link

netlify bot commented Aug 21, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit c32f1c2
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/673205d7b0dfa30008f2ea69
😎 Deploy Preview https://deploy-preview-17231--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@tay1orjones
Copy link
Member

tay1orjones commented Aug 21, 2024

To merge we need to complete the migration steps and assess if any breaking changes will be passed onto our consumers.

@guidari guidari added the type: infrastructure 🤖 Issues relating to devops, tech debt, etc. label Aug 28, 2024
Copy link
Contributor Author

renovate bot commented Oct 9, 2024

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

Copy link

netlify bot commented Oct 9, 2024

Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit b5f2e4d
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/6706e068ef75f60008546fdf
😎 Deploy Preview https://deploy-preview-17231--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 9, 2024

Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit c32f1c2
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/673205d7e7746e00087f3bd1
😎 Deploy Preview https://deploy-preview-17231--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 21, 2024

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit c32f1c2
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-web-components/deploys/673205d761c47900082101b9
😎 Deploy Preview https://deploy-preview-17231--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@tay1orjones
Copy link
Member

➜  monorepo git:(renovate/downshift-9.x) yarn why @carbon/styles
├─ @carbon/react@workspace:packages/react [4a750]
│  └─ @carbon/styles@workspace:packages/styles [1c439] (via npm:^1.68.0 [1c439])
│
├─ @carbon/react@workspace:packages/react
│  └─ @carbon/styles@workspace:packages/styles [1c439] (via npm:^1.68.0 [1c439])
│
├─ @carbon/web-components@workspace:packages/web-components
│  └─ @carbon/styles@npm:1.63.1 [40516] (via npm:1.63.1 [40516])
│
├─ carbon-components-react@workspace:packages/carbon-components-react
│  └─ @carbon/styles@workspace:packages/styles [1c439] (via npm:^1.68.0 [1c439])
│
├─ carbon-components@workspace:packages/carbon-components
│  └─ @carbon/styles@workspace:packages/styles [1c439] (via npm:^1.68.0 [1c439])
│
└─ codesandbox-styles@workspace:examples/codesandbox-styles
   └─ @carbon/styles@workspace:packages/styles [1c439] (via npm:^1.68.0 [1c439])

I'm not sure why @carbon/styles is pinned in web-components but if we update it to the same version range specified in the react package it'll remove the circular/duplicate dependency that I believe is causing this issue.

Copy link

codecov bot commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.81%. Comparing base (1a48fe3) to head (c32f1c2).
Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #17231   +/-   ##
=======================================
  Coverage   81.81%   81.81%           
=======================================
  Files         404      404           
  Lines       14097    14097           
  Branches     4414     4365   -49     
=======================================
  Hits        11534    11534           
  Misses       2401     2401           
  Partials      162      162           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@tay1orjones tay1orjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@riddhybansal riddhybansal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@riddhybansal riddhybansal added this pull request to the merge queue Nov 12, 2024
Merged via the queue into main with commit 78a52c8 Nov 12, 2024
40 checks passed
@riddhybansal riddhybansal deleted the renovate/downshift-9.x branch November 12, 2024 14:34
Copy link
Contributor

The content of this pull request will be made available as part of our next release. For the full schedule of upcoming releases, check out our Release Radar page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: one more review 👀 type: infrastructure 🤖 Issues relating to devops, tech debt, etc.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants