docs(Slug): move slug examples under experimental section #15294
Conversation
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
tw15egan
force-pushed
the
move-slug-stories
branch
from
f6c1e39
to
7e53c58
Compare
|
@mattrosno I can add it, I just had those select few props to test the components in various states. Adding the slug prop to that table isn’t going to let them change the slug that is rendered inside the component though. The knobs are great for basic state changes, but to understand how to use the slug prop I’d expect the story code itself to be more help. We could also add example usage inside the mdx file if we want |
There was a problem hiding this comment.
Storybook organization and experimental status in prop tables LGTM.
I found one bug. I don't know if this is getting addressed in a different issue or not. The label is overlapping with the slug where if you click directly on the slug icon, it selects that label not the slug. If you click outside of that label but still within the 32px slug, it then triggers the slug as expected.
|
@mattrosno fixed 👍🏻 I believe that was unique to |
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
…ign-system#15294) * docs(Slug): move slug examples under experimental section * refactor(Slug): move all slug examples under slug * test(e2e): update form test to match new location * refactor(Slug): add controls to slug example components * docs(Slug): add slug to controls table * style(TextArea): fix label width issue
Based on feedback from @mattrosno. This moves all slug-specific stories under the
unstable__slugstorybook folder. It also adds comments to components with aslugprop to mark it as an experimental prop. Also closes #15296Changelog
New
Examplesfolder underunstable__Slugin storybook. This contains an example of each component that has theslugprop.Changed
AI Formstory to underunstable__Slug, as well as all associated stylesTileslug test story to underunstable__Slug, as well as all associated stylesRadio ButtonandCheckboxslug test stories to underunstable__Slug, as well as all associated stylesExperimental:before eachslugprop type definitionRemoved
Checkboxstory file that was causing thedisabledprop to be hidden ([Bug]: Disabled prop under checkbox is not showing in the storybook #15296)SlugTesting / Reviewing
unstable__Slug --> Formunstable__Slug --> Examplesand the props work as expected