refactor(InlineLoading): add TypeScript types #15247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
andreancardona
approved these changes
Dec 4, 2023
andreancardona
added
status: ready to merge 🎉
and removed
status: one more review 👀
labels
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
tay1orjones
reviewed
Dec 4, 2023
tay1orjones
approved these changes
Dec 4, 2023
danoro96
pushed a commit
to danoro96/carbon
that referenced
this pull request
Jan 18, 2024
…5247) * refactor(InlineLoading): add TypeScript types * refactor(InlineLoading): add types and fix usages * fix(inlineloading): name prop spread ...rest --------- Co-authored-by: Andrea N. Cardona <cardona.n.andrea@gmail.com> Co-authored-by: Taylor Jones <taylor.jones826@gmail.com> Co-authored-by: Taylor Jones <tay1orjones@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13562
Adds TypeScript types to InlineLoading component.
The 13562 issue is about Loading and InlineLoading components.
But it seems like Loading has been already converted into tsx. So this PR should close 13562.
Changelog
Added TypeScript types to InlineLoading component