Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ContentSwitcher): selectionMode optional type #15061

Merged
merged 1 commit into from
Oct 30, 2023

Conversation

dbrugger
Copy link
Contributor

@dbrugger dbrugger commented Oct 30, 2023

Closes #

Update to @carbon/react to v1.41.1 doesn't work because selectionMode is a required prop there.

Changelog

Changed

  • changed selectionMode to optional property. It is already defaulted to 'automatic'.

Testing / Reviewing

{{ Add descriptions, steps or a checklist for how reviewers can verify this PR works or not }}

@dbrugger dbrugger requested a review from a team as a code owner October 30, 2023 07:37
@netlify
Copy link

netlify bot commented Oct 30, 2023

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 5f731ce
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/653f5d3a59389f00085cec31
😎 Deploy Preview https://deploy-preview-15061--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Oct 30, 2023

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 5f731ce
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/653f5d3a18f7330008df9728
😎 Deploy Preview https://deploy-preview-15061--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@tay1orjones tay1orjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@tw15egan tw15egan added this pull request to the merge queue Oct 30, 2023
Merged via the queue into carbon-design-system:main with commit 8473d79 Oct 30, 2023
16 checks passed
Tomahaawk pushed a commit to Tomahaawk/carbon that referenced this pull request Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants