feat(Combobox): allow custom value #14935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tw15egan
changed the title
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
tay1orjones
added
status: one more review 👀
and removed
status: ready for review 👀
labels
tw15egan
force-pushed
the
combobox-allow-custom-value
branch
from
25231da to
0ef61f2
Compare
alisonjoseph
approved these changes
Oct 30, 2023
alisonjoseph
added
status: ready to merge 🎉
and removed
status: one more review 👀
labels
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
tay1orjones
removed this pull request from the merge queue due to the queue being cleared
Merged
via the queue into
carbon-design-system:main
with commit Oct 31, 2023
384dca0
14 checks passed
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #14006
Adds a new prop,
allowCustomValue, that will retain the value typed into theComboboxon blur, and allow the menu to be closed withEnterwhen the value does not match an item in the list.Changelog
New
allowCustomValueprop added toComboBoxso that a user can have their value retained onEnterorBlurif it does not match any item in the list.Changed
onChangeDatato account for this new use caseTesting / Reviewing
Go to the test story, and type in an item that is not in the item list. You should be able to accept this value with Enter, and it should stay in the
Comboboxwhen the focus is lost.