Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(colors): update background tokens to be compatible with layers #10954

Merged
merged 2 commits into from
Mar 11, 2022
Merged

feat(colors): update background tokens to be compatible with layers #10954

merged 2 commits into from
Mar 11, 2022

Conversation

tay1orjones
Copy link
Member

Closes #10872

Updates background tokens to the values specified by @aagonzales in #10306

Changelog

Changed

  • update background token values

Testing / Reviewing

  • Ensure the emitted values are correct
  • Verify the results in the carbon-react-next storybook and renders as expected compared to the screenshots from the above discussion.

@tay1orjones tay1orjones requested a review from a team as a code owner March 10, 2022 20:33
@tay1orjones tay1orjones requested review from abbeyhrt and dakahn March 10, 2022 20:33
@netlify
Copy link

netlify bot commented Mar 10, 2022 •
edited
Loading

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: ac396a2

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/622aa04f1b46fc00085a4df7

😎 Browse the preview: https://deploy-preview-10954--carbon-react-next.netlify.app

@tay1orjones tay1orjones requested review from a team and aagonzales and removed request for a team March 10, 2022 20:34
@netlify
Copy link

netlify bot commented Mar 10, 2022 •
edited
Loading

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: ac396a2

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/622aa04f2e8f94000872c8ab

😎 Browse the preview: https://deploy-preview-10954--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Mar 10, 2022 •
edited
Loading

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: ac396a2

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/622aa04fe3e15600098f273d

😎 Browse the preview: https://deploy-preview-10954--carbon-components-react.netlify.app

aagonzales
aagonzales approved these changes Mar 10, 2022
View reviewed changes
Copy link
Member

@aagonzales aagonzales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🎉

@kodiakhq kodiakhq bot merged commit 6b0e702 into carbon-design-system:main Mar 11, 2022
kennylam pushed a commit to kennylam/carbon that referenced this pull request Jul 30, 2024
@annawen1
chore(tests): fix ci-check (carbon-design-system#10954)
f1171d7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abbeyhrt abbeyhrt abbeyhrt approved these changes

@aagonzales aagonzales aagonzales approved these changes

@joshblack joshblack joshblack approved these changes

@dakahn dakahn Awaiting requested review from dakahn dakahn was automatically assigned from carbon-design-system/developers-system

Assignees
No one assigned
Labels
status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update background tokens to use percent opacity
4 participants
@tay1orjones @joshblack @aagonzales @abbeyhrt