-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(progress-bar): add support for statuses #10843
Conversation
✅ Deploy Preview for carbon-react-next ready! 🔨 Explore the source changes: 80a2803 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/62385834e8c8800009a77025 😎 Browse the preview: https://deploy-preview-10843--carbon-react-next.netlify.app |
❌ Deploy Preview for carbon-elements failed.
|
❌ Deploy Preview for carbon-components-react failed.Built without sensitive environment variables
|
Thanks for putting this together @janhassel! Sorry about the delay on my end, let me know if you need anything else from me here! |
@joshblack No worries! I just resolved the last merge conflict that came up from the |
@joshblack I changed the base branch to v10 as discussed yesterday. Could you check if everything looks up to code now? |
d4d9690
to
02edafb
Compare
Ref #10670
Adds support for ProgressBar statuses.
Changelog
New
status
toProgressBar
componentChanged
Testing / Reviewing
max
0
and emitaria-invalid
Notes
InlineLoading
eslint-disable
as it claimsaria-invalid
is not supported onrole="progressbar"
. Referencing WAI-ARIA 1.1 though,aria-invalid
should be supported. Please correct me if I'm wrong.