Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(react,carbon-react): add unstable_FlexGrid #10499

Merged
merged 6 commits into from
Jan 26, 2022
Merged

feat(react,carbon-react): add unstable_FlexGrid #10499

merged 6 commits into from
Jan 26, 2022

Conversation

joshblack
Copy link
Contributor

@joshblack joshblack commented Jan 21, 2022 •
edited
Loading

Closes #10474

Add in FlexGrid component for a stable flexbox-based Grid implementation. The intention is that teams can keep using FlexGrid, Row, and Column components in v11 before moving to the CSS Grid-based implementation.

Changelog

New

  • Add FlexGrid
  • Add CSSGrid
  • Add GridSettingsContext and associated setter, getter for the context

Changed

  • Update Grid to toggle on FlexGrid and CSSGrid based on feature flag
  • Update Column to toggle classes based on the current "grid mode"
  • Move Grid stories to packages/react/src/components/Grid/next/*

Removed

  • Remove grid folder in packages/carbon-react

Testing / Reviewing

  • Verify stable grid implementation works as expected in storybook/locally
  • Verify CSS grid implementation works as expected in v11 storybook/locally
  • Consider the approach to toggling between behaviors and if there is a simpler option available that we could use instead of authoring new components

@joshblack joshblack requested review from a team as code owners January 21, 2022 19:08
@netlify
Copy link

netlify bot commented Jan 21, 2022 •
edited
Loading

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: 0b3b082

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/61f18fd5ff418b000786763b

😎 Browse the preview: https://deploy-preview-10499--carbon-react-next.netlify.app

@joshblack joshblack changed the title Feat/add flex grid feat(react,carbon-react): add unstable_FlexGrid Jan 21, 2022
@joshblack joshblack removed the request for review from tw15egan January 21, 2022 19:11
@netlify
Copy link

netlify bot commented Jan 21, 2022 •
edited
Loading

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: 0b3b082

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/61f18fd5d8d1ab00083eace9

😎 Browse the preview: https://deploy-preview-10499--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Jan 21, 2022 •
edited
Loading

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: 0b3b082

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/61f18fd5762da40008f51b32

😎 Browse the preview: https://deploy-preview-10499--carbon-components-react.netlify.app

tay1orjones
tay1orjones approved these changes Jan 25, 2022
View reviewed changes
Copy link
Member

@tay1orjones tay1orjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple questions, but I think this looks great 🎉 🏅

packages/react/src/components/Grid/Grid.js Show resolved Hide resolved
packages/react/src/index.js Show resolved Hide resolved
@joshblack joshblack requested a review from dakahn January 25, 2022 22:20
@joshblack
Copy link
Contributor Author

bump @jnm2377 when you get a sec!

jnm2377
jnm2377 approved these changes Jan 26, 2022
View reviewed changes
Copy link
Contributor

@jnm2377 jnm2377 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great!

@kodiakhq kodiakhq bot merged commit fd5db54 into carbon-design-system:main Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tay1orjones tay1orjones tay1orjones approved these changes

@jnm2377 jnm2377 jnm2377 approved these changes

@aledavila aledavila Awaiting requested review from aledavila aledavila was automatically assigned from carbon-design-system/developers-system

@dakahn dakahn Awaiting requested review from dakahn

Assignees
No one assigned
Labels
status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add component for flex grid backwards-compat
3 participants
@joshblack @tay1orjones @jnm2377