-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[modal] inputs/components should be able to span full width #4790
Comments
Hi @aagonzales does “trap focus” story address this issue? react.carbondesignsystem.com may be stale, but I think local clone shows the full width input when we shrink the browser's width. Thanks! |
@asudoh I'm not sure, I can't tell from just the code, I'd have to see it. |
@aagonzales Does https://deploy-preview-4657--carbon-components-react.netlify.com/?path=/story/modal--trap-focus work? You'll see full width text box when you shrink the browser window. Please let me know if you have any questions - Thanks! |
@asudoh thanks |
(oops sorry for the very delayed response) In the react storybook it was actually just the "default" size that wasn't doing this. The large one was also spanning the full width of the modal. |
Thank you for clarifying @aagonzales @jz2cao! Created #5046. |
Currently the modal has a padding-right of 25%. However, this padding-right should only apply to text in a modal and not restrict other components like form inputs and tables. Those should be able to span the full width of the modal container.
As-is:
To-be:
The text was updated successfully, but these errors were encountered: